android_webview/native/aw_http_auth_handler.cc - Issue 12091111: Implement Webviewclient.onReceivedSslError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_http_auth_handler.cc

Issue 12091111: Implement Webviewclient.onReceivedSslError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wasting time... Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_http_auth_handler.cc

diff --git a/android_webview/native/aw_http_auth_handler.cc b/android_webview/native/aw_http_auth_handler.cc

index 2f6a8f7635474508e7f3d525d971361cb7c1448a..8bcebbaa28075fcf2b70f2890ea49a07b7f60e67 100644

--- a/android_webview/native/aw_http_auth_handler.cc

+++ b/android_webview/native/aw_http_auth_handler.cc

@@ -56,12 +56,13 @@ void AwHttpAuthHandler::Cancel(JNIEnv* env, jobject obj) {

}

-void AwHttpAuthHandler::HandleOnUIThread(content::WebContents* web_contents) {

+bool AwHttpAuthHandler::HandleOnUIThread(content::WebContents* web_contents) {

DCHECK(web_contents);

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

AwContents* aw_contents = AwContents::FromWebContents(web_contents);

- aw_contents->OnReceivedHttpAuthRequest(http_auth_handler_, host_, realm_);

+ return aw_contents->OnReceivedHttpAuthRequest(http_auth_handler_, host_,

+ realm_);

}

// static