android_webview/browser/aw_login_delegate.cc - Issue 12091111: Implement Webviewclient.onReceivedSslError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_login_delegate.cc

Issue 12091111: Implement Webviewclient.onReceivedSslError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wasting time... Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_login_delegate.cc

diff --git a/android_webview/browser/aw_login_delegate.cc b/android_webview/browser/aw_login_delegate.cc

index d169710f88c615a5d692dfd5d64fc068bd8944f4..c2ea5a410b3b90981c72b547581b9dafb00713da 100644

--- a/android_webview/browser/aw_login_delegate.cc

+++ b/android_webview/browser/aw_login_delegate.cc

@@ -96,7 +96,10 @@ void AwLoginDelegate::HandleHttpAuthRequestOnUIThread(

WebContents* web_contents = WebContents::FromRenderViewHost(

render_view_host);

- aw_http_auth_handler_->HandleOnUIThread(web_contents);

+ if (!aw_http_auth_handler_->HandleOnUIThread(web_contents)) {

+ Cancel();

+ return;

+ }

}

void AwLoginDelegate::CancelOnIOThread() {