Implement Webviewclient.onReceivedSslError

android_webview/browser/aw_certificate_error_handler_base.h

Index: android_webview/browser/aw_certificate_error_handler_base.h
diff --git a/android_webview/browser/aw_certificate_error_handler_base.h b/android_webview/browser/aw_certificate_error_handler_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..c6e287c01ef0a573668bec592d9ca88563ed6ee9
--- /dev/null
+++ b/android_webview/browser/aw_certificate_error_handler_base.h
@@ -0,0 +1,35 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_WEBVIEW_BROWSER_AW_CERTIFICATE_ERROR_HANDLER_BASE_H_
+#define ANDROID_WEBVIEW_BROWSER_AW_CERTIFICATE_ERROR_HANDLER_BASE_H_
+
+#include "base/callback_forward.h"
+
+class GURL;
+
+namespace net {
+class X509Certificate;
+}
+
+namespace android_webview {
+
+// browser/ layer interface for AwCertificateErrorHandler, which is implemented
+// in the native/ layer, due to layering.
+class AwCertificateErrorHandlerBase {

[boliu, 2013/02/01 20:03:23]

document copiously

[sgurun-gerrit only, 2013/02/01 22:08:00]

Done.

+ public:
+  static AwCertificateErrorHandlerBase* FromID(int render_process_id,
+                                               int render_view_id);
+  virtual ~AwCertificateErrorHandlerBase();
+
+  virtual void AllowCertificateError(int cert_error,
+                                     net::X509Certificate* cert,
+                                     const GURL& request_url,
+                                     const base::Callback<void(bool)>& callback,
+                                     bool* cancel_request) = 0;
+};

[boliu, 2013/02/01 20:03:23]

Consider adding DISALLOW_COPY_AND_ASSIGN

[sgurun-gerrit only, 2013/02/01 22:08:00]

just curious. do we need this in a pure abstract class?

On 2013/02/01 20:03:23, boliu wrote:

[boliu, 2013/02/01 23:07:13]

Good point. No

+
+}  // namespace android_webview
+
+#endif  // ANDROID_WEBVIEW_BROWSER_AW_CERTIFICATE_ERROR_HANDLER_BASE_H_