Implement Webviewclient.onReceivedSslError

android_webview/browser/aw_certificate_error_handler_base.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_WEBVIEW_BROWSER_AW_CERTIFICATE_ERROR_HANDLER_BASE_H_
+#define ANDROID_WEBVIEW_BROWSER_AW_CERTIFICATE_ERROR_HANDLER_BASE_H_
+
+#include "base/callback_forward.h"
+#include "base/supports_user_data.h"
+
+class GURL;
+
+namespace content {
+class WebContents;
+}
+
+namespace net {
+class X509Certificate;
+}
+
+namespace android_webview {
+
+// browser/ layer interface for AwCertificateErrorHandler, which is implemented
+// in the native/ layer, due to layering. The implementor of the base class
+// plumbs the request to the Java side and eventually to the webviewclient. This
+// layering hides the details of native/ from browser/ layer.
+class AwCertificateErrorHandlerBase {

[joth, 2013/02/22 23:12:41]

I thought we agreed to expand this to being a AwContentClientBridge base-class?
i.e. share the userdata plumbing for all browser layer up-calls.

[sgurun-gerrit only, 2013/02/23 00:16:14]

unintentional. just forgotten.

On 2013/02/22 23:12:41, joth wrote:

+ public:
+  static AwCertificateErrorHandlerBase* FromID(int render_process_id,
+                                               int render_view_id);
+
+  // This class is invented so that the UserData registry that we inject the
+  // AwCertificateErrorHandlerBase object does now own and destroy it.
+  class UserData : public base::SupportsUserData::Data {

[joth, 2013/02/22 23:12:41]

Lets make this class internal to the .cc file.

Just put (static) methods on here -

Associate(WebContents*, AwContentClientBridge*);
AwContentClientBridge* ForWebContents(WebContents*)
AwContentClientBridge* ForId(int, int)

[sgurun-gerrit only, 2013/02/23 00:16:14]

Sure. FromID is a already established name though, let's not invent new names.
On 2013/02/22 23:12:41, joth wrote:

+   public:
+    static const void* kAwCertificateErrorHandlerBase;
+    static AwCertificateErrorHandlerBase* GetContents(
+        content::WebContents* web_contents);
+
+    explicit UserData(AwCertificateErrorHandlerBase* ptr);
+   private:
+    AwCertificateErrorHandlerBase* contents_;
+
+    DISALLOW_COPY_AND_ASSIGN(UserData);
+  };
+
+  virtual ~AwCertificateErrorHandlerBase();
+
+  virtual void AllowCertificateError(int cert_error,
+                                     net::X509Certificate* cert,
+                                     const GURL& request_url,
+                                     const base::Callback<void(bool)>& callback,
+                                     bool* cancel_request) = 0;
+};
+
+}  // namespace android_webview
+
+#endif  // ANDROID_WEBVIEW_BROWSER_AW_CERTIFICATE_ERROR_HANDLER_BASE_H_