Use SAR for positive divident by a power-of two constant divisor.

runtime/vm/intermediate_language_ia32.cc

Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc	(revision 18009)
+++ runtime/vm/intermediate_language_ia32.cc	(working copy)
@@ -1954,12 +1954,20 @@
     const intptr_t kNumTemps = 1;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
-    // Both inputs must be writable because they will be untagged.
-    summary->set_in(0, Location::RegisterLocation(EAX));
-    summary->set_in(1, Location::WritableRegister());
-    summary->set_out(Location::SameAsFirstInput());
-    // Will be used for sign extension and division.
-    summary->set_temp(0, Location::RegisterLocation(EDX));
+    if (RightIsPowerOfTwoConstant()) {
+      summary->set_in(0, Location::RequiresRegister());
+      ConstantInstr* right_constant = right()->definition()->AsConstant();
+      summary->set_in(1, Location::Constant(right_constant->value()));
+      summary->set_temp(0, Location::RequiresRegister());
+      summary->set_out(Location::SameAsFirstInput());
+    } else {
+      // Both inputs must be writable because they will be untagged.
+      summary->set_in(0, Location::RegisterLocation(EAX));
+      summary->set_in(1, Location::WritableRegister());
+      summary->set_out(Location::SameAsFirstInput());
+      // Will be used for sign extension and division.
+      summary->set_temp(0, Location::RegisterLocation(EDX));
+    }
     return summary;
   } else if (op_kind() == Token::kSHR) {
     const intptr_t kNumTemps = 0;
@@ -1996,8 +2004,7 @@
   ASSERT(left == result);
   Label* deopt = NULL;
   if (CanDeoptimize()) {
-      deopt  = compiler->AddDeoptStub(deopt_id(),
-                                      kDeoptBinarySmiOp);
+    deopt  = compiler->AddDeoptStub(deopt_id(), kDeoptBinarySmiOp);
   }
 
   if (locs()->in(1).IsConstant()) {
@@ -2022,6 +2029,38 @@
         if (deopt != NULL) __ j(OVERFLOW, deopt);
         break;
       }
+      case Token::kTRUNCDIV: {
+        const intptr_t value = Smi::Cast(constant).Value();
+        if (value == 1) {
+          // Do nothing.
+          break;
+        } else if (value == -1) {
+          // Check the corner case of dividing the 'MIN_SMI' with -1, in which
+          // case we cannot negate the result.
+          __ cmpl(left, Immediate(0x80000000));
+          __ j(EQUAL, deopt);
+          __ negl(left);
+          break;
+        }
+        ASSERT((value != 0) && Utils::IsPowerOfTwo(Utils::Abs(value)));
+        const intptr_t shift_count =
+            Utils::ShiftForPowerOfTwo(Utils::Abs(value)) + kSmiTagSize;
+        Register temp = locs()->temp(0).reg();
+        __ movl(temp, left);
+        __ sarl(temp, Immediate(31));
+        if (shift_count > 1) {

[Florian Schneider, 2013/02/04 13:04:03]

Redundant if-statment? shift_count will only be 1 if the rhs value is 1 or -1
here. Those cases are already handled above.

[srdjan, 2013/02/04 19:02:33]

Removed

+          __ shrl(temp, Immediate(32 - shift_count));
+        }
+        __ addl(left, temp);
+        if (shift_count > 0) {

[Florian Schneider, 2013/02/04 13:04:03]

shift_count will always be > 0 here because kSmiTagSize == 1.

Maybe remove this if-statement and just ASSERT(kSmiTagSize >= 1).

[srdjan, 2013/02/04 19:02:33]

Done.

+          __ sarl(left, Immediate(shift_count));
+        }
+        if (value < 0) {
+          __ negl(left);
+        }
+        __ SmiTag(left);
+        break;
+      }
       case Token::kBIT_AND: {
         // No overflow check.
         __ andl(left, Immediate(imm));