Use SAR for positive divident by a power-of two constant divisor.

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1768 matching lines @@
   __ j(BELOW_EQUAL, slow_path->entry_label());
   __ Bind(slow_path->exit_label());
 }
 
 
 static bool CanBeImmediate(const Object& constant) {
   return constant.IsSmi() &&
     Immediate(reinterpret_cast<int64_t>(constant.raw())).is_int32();
 }
 
+
 LocationSummary* BinarySmiOpInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 2;
 
   ConstantInstr* right_constant = right()->definition()->AsConstant();
   if ((right_constant != NULL) &&
       (op_kind() != Token::kTRUNCDIV) &&
       (op_kind() != Token::kSHL) &&
       (op_kind() != Token::kMUL) &&
       CanBeImmediate(right_constant->value())) {
     const intptr_t kNumTemps = 0;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RequiresRegister());
     summary->set_in(1, Location::Constant(right_constant->value()));
     summary->set_out(Location::SameAsFirstInput());
     return summary;
   }
 
   if (op_kind() == Token::kTRUNCDIV) {
-    const intptr_t kNumTemps = 1;
+    const intptr_t kNumTemps = RightIsPowerOfTwoConstant() ? 2 : 1;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     // Both inputs must be writable because they will be untagged.
     summary->set_in(0, Location::RegisterLocation(RAX));
-    summary->set_in(1, Location::WritableRegister());
+    if (kNumTemps == 1) {
+      summary->set_in(1, Location::WritableRegister());
+    } else {
+      ConstantInstr* right_constant = right()->definition()->AsConstant();
+      summary->set_in(1, Location::Constant(right_constant->value()));
+      // Temporary to hold divisor constant.
+      summary->set_temp(1, Location::RegisterLocation(RBX));
+    }
     summary->set_out(Location::SameAsFirstInput());
     // Will be used for sign extension and division.
     summary->set_temp(0, Location::RegisterLocation(RDX));
     return summary;
   } else if (op_kind() == Token::kSHR) {
     const intptr_t kNumTemps = 0;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RequiresRegister());
     summary->set_in(1, Location::FixedRegisterOrSmiConstant(right(), RCX));
@@ skipping 46 matching lines @@
         if (deopt != NULL) __ j(OVERFLOW, deopt);
         break;
       }
       case Token::kMUL: {
         // Keep left value tagged and untag right value.
         const intptr_t value = Smi::Cast(constant).Value();
         __ imulq(left, Immediate(value));
         if (deopt != NULL) __ j(OVERFLOW, deopt);
         break;
       }
+      case Token::kTRUNCDIV: {
+        Label use_div, done;
+        const intptr_t value = Smi::Cast(constant).Value();
+        ASSERT((value > 0) && Utils::IsPowerOfTwo(value));
+        __ cmpq(left, Immediate(0));
+        __ j(LESS, &use_div, Assembler::kNearJump);
+        // Positive division by power of two is an arithmetic left shift.
+        intptr_t shift_count = Utils::ShiftForPowerOfTwo(value) + kSmiTagSize;
+        __ sarq(left, Immediate(shift_count));
+        __ jmp(&done, Assembler::kNearJump);
+        __ Bind(&use_div);
+        Register right = locs()->temp(1).reg();
+        ASSERT(left == RAX);
+        ASSERT((right != RDX) && (right != RAX));
+        ASSERT(locs()->temp(0).reg() == RDX);
+        ASSERT(result == RAX);
+        __ movq(right, Immediate(value));
+        __ SmiUntag(left);
+        __ cqo();  // Sign extend RAX -> RDX:RAX.
+        __ idivq(right);  //  RAX: quotient, RDX: remainder.
+        // Check the corner case of dividing the 'MIN_SMI' with -1, in which
+        // case we cannot tag the result.
+        __ cmpq(result, Immediate(0x4000000000000000));
+        __ j(EQUAL, deopt);
+        __ Bind(&done);
+        __ SmiTag(result);
+        break;
+      }
       case Token::kBIT_AND: {
         // No overflow check.
         __ andq(left, Immediate(imm));
         break;
       }
       case Token::kBIT_OR: {
         // No overflow check.
         __ orq(left, Immediate(imm));
         break;
       }
@@ skipping 1102 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64