Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 12091095: Don't pass NCMOUSEMOVE to RenderWidgetHostViewAura (Closed)

Created:
7 years, 10 months ago by scottmg
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Don't pass NCMOUSEMOVE to RenderWidgetHostViewAura On dispatching ET_EXITED, the event is sent with a native_event of NCMOUSEMOVE, which the renderer doesn't want, so don't send it on. R=sky@chromium.org BUG=173051 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
This fixes the crash, but I'm not sure if it's really the correct place to ...
7 years, 10 months ago (2013-01-31 19:29:32 UTC) #1
sky
Any idea why we don't hit this on non-aura builds?
7 years, 10 months ago (2013-01-31 21:05:45 UTC) #2
scottmg
On 2013/01/31 21:05:45, sky wrote: > Any idea why we don't hit this on non-aura ...
7 years, 10 months ago (2013-01-31 22:17:55 UTC) #3
sky
7 years, 10 months ago (2013-01-31 22:44:18 UTC) #4
Ananta came over and described this to me. LGTM

Powered by Google App Engine
This is Rietveld 408576698