chrome/renderer/extensions/scoped_persistent.h - Issue 12091004: POSIX: re-enable strict aliasing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/scoped_persistent.h

Issue 12091004: POSIX: re-enable strict aliasing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/scoped_persistent.h

diff --git a/chrome/renderer/extensions/scoped_persistent.h b/chrome/renderer/extensions/scoped_persistent.h

index 6f60fad185b67eff8a944bde5a314921fad4422c..08d31583730a6e1cbad39c0703dbb3709ca8b5b8 100644

--- a/chrome/renderer/extensions/scoped_persistent.h

+++ b/chrome/renderer/extensions/scoped_persistent.h

@@ -47,8 +47,7 @@ class ScopedPersistent {

// TODO(dcarney): Remove this function

// This is an unsafe access to the underlying handle

v8::Handle<T> get() const {

- return *reinterpret_cast<v8::Handle<T>*>(

- const_cast<v8::Persistent<T>* >(&handle_));

+ return bit_cast<v8::Handle<T> >(handle_);

}

v8::Handle<T> NewHandle() const {