chrome/browser/crash_handler_host_linux.cc - Issue 12091004: POSIX: re-enable strict aliasing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/crash_handler_host_linux.cc

Issue 12091004: POSIX: re-enable strict aliasing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/crash_handler_host_linux.cc

diff --git a/chrome/browser/crash_handler_host_linux.cc b/chrome/browser/crash_handler_host_linux.cc

index 27ad89bd072fc85c9cd090a5fa7102bb4edcc173..517c3d45c98ee3df3d5e197cc75822b703d82170 100644

--- a/chrome/browser/crash_handler_host_linux.cc

+++ b/chrome/browser/crash_handler_host_linux.cc

@@ -235,8 +235,10 @@ void CrashHandlerHostLinux::OnFileCanReadWithoutBlocking(int fd) {

(void) HANDLE_EINTR(close(reinterpret_cast<int*>(CMSG_DATA(hdr))[i]));

return;

} else {

- partner_fd = reinterpret_cast<int*>(CMSG_DATA(hdr))[0];

- signal_fd = reinterpret_cast<int*>(CMSG_DATA(hdr))[1];

+ int fds[2] = { -1, -1 };

Mark Mentovai 2013/08/15 14:29:07 Don’t initialize, the memcpy follows immediately.

Paweł Hajdan Jr. 2013/08/19 20:09:37 Done.

+ memcpy(fds, CMSG_DATA(hdr), sizeof(fds));

+ partner_fd = fds[0];

+ signal_fd = fds[1];

}

} else if (hdr->cmsg_type == SCM_CREDENTIALS) {

const struct ucred *cred =

« no previous file with comments | « chrome/app/breakpad_linux.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »