Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: build/common.gypi

Issue 12091004: POSIX: re-enable strict aliasing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/browser/crash_handler_host_linux.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2312 matching lines...) Expand 10 before | Expand all | Expand 10 after
2323 # so remove any existing warning-enabling flags like -Wall. 2323 # so remove any existing warning-enabling flags like -Wall.
2324 'cflags!': [ 2324 'cflags!': [
2325 '-Wall', 2325 '-Wall',
2326 '-Wextra', 2326 '-Wextra',
2327 ], 2327 ],
2328 'cflags_cc': [ 2328 'cflags_cc': [
2329 # Don't warn about hash_map in third-party code. 2329 # Don't warn about hash_map in third-party code.
2330 '-Wno-deprecated', 2330 '-Wno-deprecated',
2331 ], 2331 ],
2332 'cflags': [ 2332 'cflags': [
2333 # Do not assume the code is strict-aliasing-safe. This can induce
2334 # strange crashes, and we ignore warnings in third-party code.
2335 # The reference bug for this is http://crbug.com/32204 .
2336 '-fno-strict-aliasing',
2333 # Don't warn about printf format problems. 2337 # Don't warn about printf format problems.
2334 # This is off by default in gcc but on in Ubuntu's gcc(!). 2338 # This is off by default in gcc but on in Ubuntu's gcc(!).
2335 '-Wno-format', 2339 '-Wno-format',
2336 ], 2340 ],
2337 'cflags_cc!': [ 2341 'cflags_cc!': [
2338 # TODO(fischman): remove this. 2342 # TODO(fischman): remove this.
2339 # http://code.google.com/p/chromium/issues/detail?id=90453 2343 # http://code.google.com/p/chromium/issues/detail?id=90453
2340 '-Wsign-compare', 2344 '-Wsign-compare',
2341 ] 2345 ]
2342 }], 2346 }],
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
2746 'werror%': '-Werror', 2750 'werror%': '-Werror',
2747 'libraries_for_target%': '', 2751 'libraries_for_target%': '',
2748 }, 2752 },
2749 'defines': [ 2753 'defines': [
2750 '_FILE_OFFSET_BITS=64', 2754 '_FILE_OFFSET_BITS=64',
2751 ], 2755 ],
2752 'cflags': [ 2756 'cflags': [
2753 '<(werror)', # See note above about the werror variable. 2757 '<(werror)', # See note above about the werror variable.
2754 '-pthread', 2758 '-pthread',
2755 '-fno-exceptions', 2759 '-fno-exceptions',
2756 '-fno-strict-aliasing', # See http://crbug.com/32204
2757 '-Wall', 2760 '-Wall',
2758 # TODO(evan): turn this back on once all the builds work. 2761 # TODO(evan): turn this back on once all the builds work.
2759 # '-Wextra', 2762 # '-Wextra',
2760 # Don't warn about unused function params. We use those everywhere. 2763 # Don't warn about unused function params. We use those everywhere.
2761 '-Wno-unused-parameter', 2764 '-Wno-unused-parameter',
2762 # Don't warn about the "struct foo f = {0};" initialization pattern. 2765 # Don't warn about the "struct foo f = {0};" initialization pattern.
2763 '-Wno-missing-field-initializers', 2766 '-Wno-missing-field-initializers',
2764 # Don't export any symbols (for example, to plugins we dlopen()). 2767 # Don't export any symbols (for example, to plugins we dlopen()).
2765 # Note: this is *required* to make some plugins work. 2768 # Note: this is *required* to make some plugins work.
2766 '-fvisibility=hidden', 2769 '-fvisibility=hidden',
(...skipping 1942 matching lines...) Expand 10 before | Expand all | Expand 10 after
4709 # settings in target dicts. SYMROOT is a special case, because many other 4712 # settings in target dicts. SYMROOT is a special case, because many other
4710 # Xcode variables depend on it, including variables such as 4713 # Xcode variables depend on it, including variables such as
4711 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4714 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4712 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4715 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4713 # files to appear (when present) in the UI as actual files and not red 4716 # files to appear (when present) in the UI as actual files and not red
4714 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4717 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4715 # and therefore SYMROOT, needs to be set at the project level. 4718 # and therefore SYMROOT, needs to be set at the project level.
4716 'SYMROOT': '<(DEPTH)/xcodebuild', 4719 'SYMROOT': '<(DEPTH)/xcodebuild',
4717 }, 4720 },
4718 } 4721 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app/breakpad_linux.cc » ('j') | chrome/browser/crash_handler_host_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698