Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 1209093005: Revert "Enhance dart:js interop in a backwards compatible manner." (Closed)

Created:
5 years, 5 months ago by Jacob
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Enhance dart:js interop in a backwards compatible manner." This reverts commit ac32e37ab1300cb1ce1cd081f050ff1d04e54cbe. BUG= Committed: https://github.com/dart-lang/sdk/commit/7e9e4d89d3541bf89784443777c8e46dda9f42cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1182 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 16 chunks +25 lines, -478 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/html/js_array_test.dart View 1 chunk +0 lines, -556 lines 0 comments Download
D tests/html/js_typed_interop_test.dart View 1 chunk +0 lines, -139 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jacob
TBR.. rollback while fixing tests
5 years, 5 months ago (2015-06-26 17:28:59 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as 7e9e4d89d3541bf89784443777c8e46dda9f42cd (presubmit successful).
5 years, 5 months ago (2015-06-26 17:29:30 UTC) #3
vsm
5 years, 5 months ago (2015-06-26 17:29:43 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698