Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1209083005: Fix invalid tests to not run when minimal. (Closed)

Created:
5 years, 5 months ago by Karl
Modified:
5 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix invalid tests to not run when minimal. Deals with fact that minimal builds generate simple "generic" error messages, rather than descriptive error messages. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7b60eb77a39f9e578cd314a7a45fea0a133fceb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tests_lit/llvm2ice_tests/invalid.test View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
5 years, 5 months ago (2015-06-30 21:26:30 UTC) #2
Jim Stichnoth
lgtm
5 years, 5 months ago (2015-06-30 21:28:59 UTC) #3
Karl
5 years, 5 months ago (2015-06-30 21:30:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b60eb77a39f9e578cd314a7a45fea0a133fceb7 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698