Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(116)

Issue 1209063003: Blank assets for staging new media UI, take two. (Closed)

Created:
4 years, 10 months ago by liberato (no reviews please)
Modified:
4 years, 10 months ago
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-css, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, vcarbune.chromium, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Blank assets for staging new media UI, take two. This CL adds new zero-length png and css assets, so that they can be referenced in blink_platform_impl.cc (etc.) for staging, before the main CL in WebKit lands. The css files also have to be non-empty, else the gn mandoline builds break. not sure why the 'cl try' on the original didn't fail. This CL does not change any existing functionality. It also makes the css files non-empty, since that breaks gn builds. BUG=446350, 488625, 487344 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A Source/core/css/mediaControlsAndroidNew.css View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/css/mediaControlsNew.css View 1 chunk +1 line, -0 lines 0 comments Download
M public/blink_image_resources.grd View 2 chunks +14 lines, -0 lines 0 comments Download
M public/blink_resources.grd View 2 chunks +2 lines, -0 lines 0 comments Download
A public/default_100_percent/blink/1x1.png View Binary file 0 comments Download

Messages

Total messages: 9 (2 generated)
liberato (no reviews please)
Hi The previous version of this CL (https://codereview.chromium.org/1207463002/) broke the blink roll, even though the ...
4 years, 10 months ago (2015-06-25 20:12:13 UTC) #2
eae
LGTM
4 years, 10 months ago (2015-06-25 20:15:05 UTC) #3
pdr.
On 2015/06/25 at 20:15:05, eae wrote: > LGTM LGTM
4 years, 10 months ago (2015-06-25 20:16:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209063003/1
4 years, 10 months ago (2015-06-25 20:17:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197858
4 years, 10 months ago (2015-06-25 21:16:32 UTC) #7
liberato (no reviews please)
On 2015/06/25 21:16:32, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 10 months ago (2015-06-25 21:17:08 UTC) #8
liberato (no reviews please)
4 years, 10 months ago (2015-06-25 21:17:09 UTC) #9
Message was sent while issue was closed.
On 2015/06/25 21:16:32, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=197858

thanks, all!

-fl

Powered by Google App Engine
This is Rietveld 408576698