Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1209043010: Add Unicode Variation Selector support to harfBuzzGetGlyph on Linux (Closed)

Created:
5 years, 5 months ago by kojii
Modified:
5 years, 5 months ago
Reviewers:
behdad_google, eae, drott
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add Unicode Variation Selector support to harfBuzzGetGlyph on Linux Most of the work to support Unicode Variation Selector was done in a separate CL[1], but it was not enabled for Linux due to crbug.com/462689. With the bundled harfbuzz on Linux stabilized, this patch enables the Unicode Variation Selector support on Linux. [1] https://codereview.chromium.org/1149693002 BUG=383580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198565

Patch Set 1 #

Patch Set 2 : Removed the failure expectation for Linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzFace.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kojii
PTAL.
5 years, 5 months ago (2015-07-08 08:46:48 UTC) #2
eae
LGTM
5 years, 5 months ago (2015-07-08 14:25:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209043010/20001
5 years, 5 months ago (2015-07-09 05:25:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198565
5 years, 5 months ago (2015-07-09 05:29:16 UTC) #6
jbroman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1229923003/ by jbroman@chromium.org. ...
5 years, 5 months ago (2015-07-09 15:48:10 UTC) #7
kojii
5 years, 5 months ago (2015-07-09 16:00:56 UTC) #8
Message was sent while issue was closed.
From the IRC as a record for investigations:

use_goma=1 chromeos=1 clang=1 clang_use_chrome_plugins=1
libharfbuzz-dev version: 0.9.27-1ubuntu1

use_system_harfbuzz=0 gives me a longer list of warnings over hidden symbols,
which are being treated as errors. http://pastebin.com/5Up4nyBv

Powered by Google App Engine
This is Rietveld 408576698