Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1209033016: Remove dead code from DartController (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove dead code from DartController This code existed to service WebView, which no longer exists. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/41d3906ce7ccde2cd20bd470034dd7bfe191f2d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -109 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/script/dart_controller.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/script/dart_library_provider_webview.h View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/engine/core/script/dart_library_provider_webview.cc View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-01 16:10:22 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-07-01 16:20:37 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-01 16:34:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41d3906ce7ccde2cd20bd470034dd7bfe191f2d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698