Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1209033011: Pull in the latest upstream testharness.js changes. (Closed)

Created:
5 years, 5 months ago by ortuno
Modified:
5 years, 5 months ago
Reviewers:
jsbell
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-temp
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Pull in the latest upstream testharness.js changes. This pulls in the latest changes from testharness.js respository: https://github.com/w3c/testharness.js Mainly bug fixes; now promise_test run sequentially. There was a change in the way idlharness handled optional arguments, so this change also updates a rtcpeerconnection-idl-expected.txt BUG=433962 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198650

Patch Set 1 : Update testharness.js and idlharness.js #

Patch Set 2 : Pull CL that fixes worker tests #

Patch Set 3 : git cl try #

Patch Set 4 : Fix rtcpeerconnection-idl test #

Total comments: 1

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+679 lines, -281 lines) Patch
M LayoutTests/http/tests/resources/testharness.js View 1 14 chunks +209 lines, -73 lines 0 comments Download
M LayoutTests/http/tests/w3c/resources/idlharness.js View 4 chunks +22 lines, -27 lines 0 comments Download
M LayoutTests/http/tests/w3c/resources/testharness.js View 1 14 chunks +209 lines, -73 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/resources/idlharness.js View 4 chunks +22 lines, -27 lines 0 comments Download
M LayoutTests/resources/testharness.js View 1 14 chunks +209 lines, -73 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209033011/40001
5 years, 5 months ago (2015-07-09 19:29:21 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/69936) (exceeded global ...
5 years, 5 months ago (2015-07-09 20:42:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209033011/60001
5 years, 5 months ago (2015-07-09 21:14:52 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209033011/80001
5 years, 5 months ago (2015-07-09 21:49:41 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-09 23:22:33 UTC) #11
jsbell
lgtm https://codereview.chromium.org/1209033011/diff/80001/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js File LayoutTests/http/tests/cachestorage/script-tests/cache-match.js (right): https://codereview.chromium.org/1209033011/diff/80001/LayoutTests/http/tests/cachestorage/script-tests/cache-match.js#newcode453 LayoutTests/http/tests/cachestorage/script-tests/cache-match.js:453: var request = new Request(entries.a.request.clone(), {method: 'POST'}); Rebase ...
5 years, 5 months ago (2015-07-09 23:44:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209033011/100001
5 years, 5 months ago (2015-07-10 01:43:05 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 02:49:36 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198650

Powered by Google App Engine
This is Rietveld 408576698