Source/core/layout/compositing/CompositingLayerAssigner.cpp - Issue 1209033009: Clear the groupedMapping parameter in layers when removed from the group

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/compositing/CompositingLayerAssigner.cpp

Issue 1209033009: Clear the groupedMapping parameter in layers when removed from the group (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch to enum Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp ('k') | Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/compositing/CompositingLayerAssigner.cpp

diff --git a/Source/core/layout/compositing/CompositingLayerAssigner.cpp b/Source/core/layout/compositing/CompositingLayerAssigner.cpp

index ebbe2e4d60c3b8a5107543d89478c8395bf45a1b..401a907a1a036010f072591c0ab841bfe2a4802b 100644

--- a/Source/core/layout/compositing/CompositingLayerAssigner.cpp

+++ b/Source/core/layout/compositing/CompositingLayerAssigner.cpp

@@ -210,7 +210,7 @@ void CompositingLayerAssigner::updateSquashingAssignment(DeprecatedPaintLayer* l

// Before removing |layer| from an already-existing squashing layer that may have other content, issue a paint invalidation.

m_compositor->paintInvalidationOnCompositingChange(layer);

layer->groupedMapping()->setNeedsGraphicsLayerUpdate(GraphicsLayerUpdateSubtree);

- layer->setGroupedMapping(nullptr);

+ layer->setGroupedMapping(nullptr, DeprecatedPaintLayer::InvalidateLayerAndRemoveFromMapping);

}

// If we need to issue paint invalidations, do so now that we've removed it from a squashed layer.