Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.h

Issue 1209033009: Clear the groupedMapping parameter in layers when removed from the group (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switch to enum Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 GraphicsLayer* graphicsLayerBacking() const; 309 GraphicsLayer* graphicsLayerBacking() const;
310 GraphicsLayer* graphicsLayerBackingForScrolling() const; 310 GraphicsLayer* graphicsLayerBackingForScrolling() const;
311 // NOTE: If you are using hasCompositedDeprecatedPaintLayerMapping to determ ine the state of compositing for this layer, 311 // NOTE: If you are using hasCompositedDeprecatedPaintLayerMapping to determ ine the state of compositing for this layer,
312 // (and not just to do bookkeeping related to the mapping like, say, allocat ing or deallocating a mapping), 312 // (and not just to do bookkeeping related to the mapping like, say, allocat ing or deallocating a mapping),
313 // then you may have incorrect logic. Use compositingState() instead. 313 // then you may have incorrect logic. Use compositingState() instead.
314 // FIXME: This is identical to null checking compositedDeprecatedPaintLayerM apping(), why not just call that? 314 // FIXME: This is identical to null checking compositedDeprecatedPaintLayerM apping(), why not just call that?
315 bool hasCompositedDeprecatedPaintLayerMapping() const { return m_compositedD eprecatedPaintLayerMapping.get(); } 315 bool hasCompositedDeprecatedPaintLayerMapping() const { return m_compositedD eprecatedPaintLayerMapping.get(); }
316 void ensureCompositedDeprecatedPaintLayerMapping(); 316 void ensureCompositedDeprecatedPaintLayerMapping();
317 void clearCompositedDeprecatedPaintLayerMapping(bool layerBeingDestroyed = f alse); 317 void clearCompositedDeprecatedPaintLayerMapping(bool layerBeingDestroyed = f alse);
318 CompositedDeprecatedPaintLayerMapping* groupedMapping() const { return m_gro upedMapping; } 318 CompositedDeprecatedPaintLayerMapping* groupedMapping() const { return m_gro upedMapping; }
319 void setGroupedMapping(CompositedDeprecatedPaintLayerMapping* groupedMapping , bool layerBeingDestroyed = false); 319 enum SetGroupMappingOptions {
320 InvalidateLayerAndRemoveFromMapping,
321 DoNotInvalidateLayerAndRemoveFromMapping
322 };
323 void setGroupedMapping(CompositedDeprecatedPaintLayerMapping*, SetGroupMappi ngOptions);
320 324
321 bool hasCompositedMask() const; 325 bool hasCompositedMask() const;
322 bool hasCompositedClippingMask() const; 326 bool hasCompositedClippingMask() const;
323 bool needsCompositedScrolling() const { return m_scrollableArea && m_scrolla bleArea->needsCompositedScrolling(); } 327 bool needsCompositedScrolling() const { return m_scrollableArea && m_scrolla bleArea->needsCompositedScrolling(); }
324 328
325 // Computes the position of the given layout object in the space of |paintIn validationContainer|. 329 // Computes the position of the given layout object in the space of |paintIn validationContainer|.
326 // FIXME: invert the logic to have paint invalidation containers take care o f painting objects into them, rather than the reverse. 330 // FIXME: invert the logic to have paint invalidation containers take care o f painting objects into them, rather than the reverse.
327 // This will allow us to clean up this static method messiness. 331 // This will allow us to clean up this static method messiness.
328 static LayoutPoint positionFromPaintInvalidationBacking(const LayoutObject*, const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidation State* = 0); 332 static LayoutPoint positionFromPaintInvalidationBacking(const LayoutObject*, const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidation State* = 0);
329 333
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 717
714 } // namespace blink 718 } // namespace blink
715 719
716 #ifndef NDEBUG 720 #ifndef NDEBUG
717 // Outside the WebCore namespace for ease of invocation from gdb. 721 // Outside the WebCore namespace for ease of invocation from gdb.
718 void showLayerTree(const blink::DeprecatedPaintLayer*); 722 void showLayerTree(const blink::DeprecatedPaintLayer*);
719 void showLayerTree(const blink::LayoutObject*); 723 void showLayerTree(const blink::LayoutObject*);
720 #endif 724 #endif
721 725
722 #endif // Layer_h 726 #endif // Layer_h
OLDNEW
« no previous file with comments | « Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp ('k') | Source/core/paint/DeprecatedPaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698