Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1209033002: SP: Invalidate paint for the entire layout tree when ending printing. (Closed)

Created:
4 years, 10 months ago by chrishtr
Modified:
4 years, 10 months ago
Reviewers:
Xianzhu
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

SP: Invalidate paint for the entire layout tree when ending printing. This is a big hammer, but forceLayoutForPagination() is one-off code that has effects which are not tracked by our existing dirty bits system. BUG=504241 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197862

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M Source/core/frame/LocalFrame.cpp View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 2 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
chrishtr
4 years, 10 months ago (2015-06-25 18:40:19 UTC) #2
Xianzhu
lgtm https://codereview.chromium.org/1209033002/diff/20001/Source/core/layout/LayoutView.cpp File Source/core/layout/LayoutView.cpp (right): https://codereview.chromium.org/1209033002/diff/20001/Source/core/layout/LayoutView.cpp#newcode387 Source/core/layout/LayoutView.cpp:387: Nit: Too many empty lines. https://codereview.chromium.org/1209033002/diff/20001/Source/core/layout/LayoutView.cpp#newcode399 Source/core/layout/LayoutView.cpp:399: Nit: ...
4 years, 10 months ago (2015-06-25 18:50:05 UTC) #3
chrishtr
https://codereview.chromium.org/1209033002/diff/20001/Source/core/layout/LayoutView.cpp File Source/core/layout/LayoutView.cpp (right): https://codereview.chromium.org/1209033002/diff/20001/Source/core/layout/LayoutView.cpp#newcode387 Source/core/layout/LayoutView.cpp:387: On 2015/06/25 at 18:50:05, Xianzhu wrote: > Nit: Too ...
4 years, 10 months ago (2015-06-25 18:55:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209033002/40001
4 years, 10 months ago (2015-06-25 18:56:20 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2015-06-25 19:21:45 UTC) #9
chrishtr
Added setting needs layout on the LayoutView.
4 years, 10 months ago (2015-06-25 20:30:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209033002/80001
4 years, 10 months ago (2015-06-25 20:32:01 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 22:05:18 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197862

Powered by Google App Engine
This is Rietveld 408576698