Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1209013002: [DevTools] Add test for screen size and position overrides. (Closed)

Created:
5 years, 6 months ago by dgozman
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Add test for screen size and position overrides. BUG=393493 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -19 lines) Patch
A + LayoutTests/inspector/device-emulation/device-emulation-insets.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/device-emulation/device-emulation-insets-expected.txt View 3 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-restore.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-test.js View 3 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Take a look please.
5 years, 6 months ago (2015-06-25 17:27:37 UTC) #2
pfeldman
lgtm
5 years, 6 months ago (2015-06-26 12:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209013002/1
5 years, 6 months ago (2015-06-26 12:42:52 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 13:59:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197917

Powered by Google App Engine
This is Rietveld 408576698