Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 12090114: Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in… (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Replace or exclude MMX intrinsics in yuv_convert_simd_x86 due to lack of VS2010 support for them in Win64 On Win64, exclude MMX version in ChooseFilterYUVRowsProc; still use faster SSE2 version. Replace _mm_empty() with new yasm that implements EmptyRegisterState_MMX() with emms in EmptyRegisterState(), ConvertYUVToRGB32_MMX(...), and ConvertYUVToRGB32_SSE(...). This patch does not fix other win64 media link errors; more work remains for bug 172938. Committing for wolenetz from : https://codereview.chromium.org/12082087/#msg15 BUG=172938, 166496 R=wolenetz@chromium.org TBR=wolenetz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180141

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M media/base/simd/convert_yuv_to_rgb_x86.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A media/base/simd/empty_register_state_mmx.asm View 1 1 chunk +23 lines, -0 lines 0 comments Download
M media/base/yuv_convert.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/yuv_convert.cc View 3 chunks +28 lines, -3 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12090114/3001
7 years, 10 months ago (2013-02-01 07:48:43 UTC) #1
commit-bot: I haz the power
Presubmit check for 12090114-3001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-01 07:48:45 UTC) #2
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 07:51:24 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698