Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: media/video/capture/video_capture_device.h

Issue 12090109: Tab Capture: Backing store readbacks to YV12 VideoFrames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fix per wjia Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/video_capture_device.h
diff --git a/media/video/capture/video_capture_device.h b/media/video/capture/video_capture_device.h
index fdfd8bea25b94fed9848241e5745323f8bdffd4a..6181b6207010d8402b5bbb645a5314ed6790206a 100644
--- a/media/video/capture/video_capture_device.h
+++ b/media/video/capture/video_capture_device.h
@@ -36,15 +36,23 @@ class MEDIA_EXPORT VideoCaptureDevice {
class MEDIA_EXPORT EventHandler {
public:
- // Captured a new video frame.
+ // Captured a new video frame as a raw buffer. The size, color format, and
+ // layout are taken from the parameters specified by an earlier call to
+ // OnFrameInfo(). |data| must be packed, with no padding between rows and/or
+ // color planes.
virtual void OnIncomingCapturedFrame(const uint8* data,
int length,
base::Time timestamp) = 0;
- // An error has occurred that can not be handled
- // and VideoCaptureDevice must be DeAllocated.
+ // Captured a new video frame, held in a VideoFrame container. |frame| must
+ // be allocated as RGB32, YV12 or I420, and the size must match that
+ // specified by an earlier call to OnFrameInfo().
+ virtual void OnIncomingCapturedVideoFrame(media::VideoFrame* frame,
+ base::Time timestamp) = 0;
+ // An error has occurred that cannot be handled and VideoCaptureDevice must
+ // be DeAllocate()-ed.
virtual void OnError() = 0;
- // Called when VideoCaptureDevice::Allocate has been called
- // to inform of the resulting frame size and color format.
+ // Called when VideoCaptureDevice::Allocate() has been called to inform of
+ // the resulting frame size.
virtual void OnFrameInfo(const VideoCaptureCapability& info) = 0;
protected:
@@ -59,9 +67,9 @@ class MEDIA_EXPORT VideoCaptureDevice {
static void GetDeviceNames(Names* device_names);
// Prepare the camera for use. After this function has been called no other
- // applications can use the camera. On completion EventHandler::OnFrameInfo is
- // called informing of the resulting resolution and frame rate.
- // DeAllocate must be called before this function can be called again and
+ // applications can use the camera. On completion EventHandler::OnFrameInfo()
+ // is called informing of the resulting resolution and frame rate.
+ // DeAllocate() must be called before this function can be called again and
// before the object is deleted.
virtual void Allocate(int width,
int height,
@@ -74,9 +82,9 @@ class MEDIA_EXPORT VideoCaptureDevice {
// Stop capturing video frames.
virtual void Stop() = 0;
- // DeAllocates the camera. This means other applications can use it.
- // After this function has been called the Capture device is reset to the
- // state it was when created.
+ // Deallocates the camera. This means other applications can use it. After
+ // this function has been called the capture device is reset to the state it
+ // was when created.
virtual void DeAllocate() = 0;
// Get the name of the capture device.
« no previous file with comments | « media/video/capture/screen/screen_capture_device_unittest.cc ('k') | media/video/capture/video_capture_device_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698