media/video/capture/mac/video_capture_device_qtkit_mac.mm - Issue 12090109: Tab Capture: Backing store readbacks to YV12 VideoFrames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/mac/video_capture_device_qtkit_mac.mm

Issue 12090109: Tab Capture: Backing store readbacks to YV12 VideoFrames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Style fix per wjia Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/capture/mac/video_capture_device_qtkit_mac.mm

diff --git a/media/video/capture/mac/video_capture_device_qtkit_mac.mm b/media/video/capture/mac/video_capture_device_qtkit_mac.mm

index ddc2790edde958a19450523e05966b473f597b70..0dcec7778466f56a44015479e92f9fbb912962aa 100644

--- a/media/video/capture/mac/video_capture_device_qtkit_mac.mm

+++ b/media/video/capture/mac/video_capture_device_qtkit_mac.mm

@@ -230,6 +230,9 @@

// but VideoCaptureController::OnIncomingCapturedFrame() requires

// it to do so. Plumbing things through is intrusive, for now

// just deliver an adjusted buffer.

+ // TODO(nick): This workaround could probably be eliminated by using

+ // VideoCaptureController::OnIncomingCapturedVideoFrame, which supports

+ // pitches.

UInt8* addressToPass = static_cast<UInt8*>(baseAddress);

size_t expectedBytesPerRow = frameWidth_ * 4;

if (bytesPerRow > expectedBytesPerRow) {