Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: dart/dart.gyp

Issue 12090092: Build the Editor from GYP/build.py. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/editor/build/.gitignore » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/dart.gyp
diff --git a/dart/dart.gyp b/dart/dart.gyp
index d206fccbe4e269668a628029d0d2accdb1ef6959..9778fc3720ea67689587e96b5d0a8a575db6c4c1 100644
--- a/dart/dart.gyp
+++ b/dart/dart.gyp
@@ -114,6 +114,44 @@
],
},
{
+ 'target_name': 'editor',
+ 'type': 'none',
+ 'dependencies': [
+ 'editor/build/generated/editor_deps.gyp:editor_deps',
+
+ # This dependency on create_sdk does not mean that the Editor
+ # is rebuilt if the SDK is. It only means that when you build
+ # the Editor, you should also build the SDK. If we wanted to
+ # make sure that the editor is rebuilt when the SDK is, we
+ # should list a *file* in PRODUCT_DIR which the action below
+ # uses as input.
+ # This is the desired behavior as we would otherwise have to
+ # rebuild the editor each time the VM, dart2js, or library
+ # code changes.
+ 'create_sdk',
+ ],
+ 'actions': [
+ {
+ 'action_name': 'create_editor_py',
+ 'inputs': [
+ 'tools/create_editor.py',
+ '<(SHARED_INTERMEDIATE_DIR)/editor_deps/editor.stamp',
+ '<!@(["python", "tools/list_files.py", "", "editor/tools/features/com.google.dart.tools.deploy.feature_releng"])',
+ ],
+ 'outputs': [
+ '<(PRODUCT_DIR)/editor/VERSION',
+ ],
+ 'action': [
+ 'python',
+ 'tools/create_editor.py',
+ '--out', '<(PRODUCT_DIR)/editor',
+ '--build', '<(INTERMEDIATE_DIR)',
+ ],
+ 'message': 'Creating editor.',
+ },
+ ],
+ },
+ {
'target_name': 'samples',
'type': 'none',
'dependencies': [
« no previous file with comments | « no previous file | dart/editor/build/.gitignore » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698