Issue 12090060: Merge 140788

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12090060: Merge 140788 (Closed)

Created:
7 years, 10 months ago by tkent

Modified:
7 years, 10 months ago

Reviewers:
tkent

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/

Visibility:
Public.

More Reviews

Description

Merge 140788 > INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove unused DateTimeHourFieldElement::valueAsInteger > https://bugs.webkit.org/show_bug.cgi?id=107915 > > Reviewed by Kentaro Hara. > > DateTimeHourFieldElement::valueAsInteger is never called. Remove it and > make valueAsInteger non-public. > > No new tests. This shouldn't change any behavior. > > * html/shadow/DateTimeFieldElement.h: > (DateTimeFieldElement): Make valueAsInteger protected. > * html/shadow/DateTimeFieldElements.cpp: > Remove DateTimeHourFieldElement::valueAsInteger. > (WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): > Remove unnecessary DateTimeNumericFieldElement:: prefix. > * html/shadow/DateTimeFieldElements.h: > (DateTimeHourFieldElement): Remove valueAsInteger. > * html/shadow/DateTimeNumericFieldElement.h: > (DateTimeNumericFieldElement): > Make valueAsInteger FINAL. BUG=crbug.com/172199 TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141197

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	Source/WebCore/html/shadow/DateTimeFieldElement.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/WebCore/html/shadow/DateTimeFieldElements.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/WebCore/html/shadow/DateTimeFieldElements.cpp	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	Source/WebCore/html/shadow/DateTimeNumericFieldElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages