Split the comment strings in docs extraction on newlines.

tools/dom/docs/lib/docs.dart

 /**
  * A library for extracting the documentation from the various HTML libraries
  * ([dart:html], [dart:svg], [dart:web_audio], [dart:indexed_db]) and saving
  * those documentation comments to a JSON file.
  */
 
 library docs;
 
 import '../../../../sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart';
 import '../../../../sdk/lib/_internal/dartdoc/lib/src/json_serializer.dart';
@@ skipping 11 matching lines @@
  * Converts the libraries in [HTML_LIBRARY_NAMES] to a json file at [jsonPath]
  * given the library path at [libPath].
  *
  * The json output looks like:
  *     {
  *       $library_name: {
  *         $interface_name: {
  *           comment: "$comment"
  *           members: {
  *             $member: [
- *               $comment1,
+ *               [$comment1line1,
+ *                $comment1line2,
+ *                ...],
  *               ...
  *             ],
  *             ...
  *           }
  *         },
  *         ...
  *       },
  *       ...
  *     }
  *
@@ skipping 45 matching lines @@
         libMirror.classes.values.toList(), ignoreDocsEditable: true);
 
     for (ClassMirror classMirror in sortedClasses) {
       var classJson = {};
       var sortedMembers = _sortAndFilterMirrors(
           classMirror.members.values.toList());
 
       var membersJson = {};
       for (var memberMirror in sortedMembers) {
         var memberDomName = domNames(memberMirror)[0];
-        var memberComment = computeUntrimmedCommentAsList(memberMirror);
+        var memberComment = _splitCommentsByNewline(
+            computeUntrimmedCommentAsList(memberMirror));
 
         // Remove interface name from Dom Name.
         if (memberDomName.indexOf('.') >= 0) {
           memberDomName = memberDomName.slice(memberDomName.indexOf('.') + 1);
         }
 
         if (!memberComment.isEmpty) {
           membersJson.putIfAbsent(memberDomName, () => memberComment);
         }
       }
 
       // Only include the comment if DocsEditable is set.
-      var classComment = computeUntrimmedCommentAsList(classMirror);
+      var classComment = _splitCommentsByNewline(
+          computeUntrimmedCommentAsList(classMirror));
       if (!classComment.isEmpty &&
           findMetadata(classMirror.metadata, 'DocsEditable') != null) {
         classJson.putIfAbsent('comment', () => classComment);
       }
       if (!membersJson.isEmpty) {
         classJson.putIfAbsent('members', () =>
             membersJson);
       }
 
       if (!classJson.isEmpty) {
@@ skipping 26 matching lines @@
           : true))
       .toList();
 
   filteredMirrors.sort((x, y) =>
     domNames(x)[0].toUpperCase().compareTo(
     domNames(y)[0].toUpperCase()));
 
   return filteredMirrors;
 }
 
+List<String> _splitCommentsByNewline(List<String> comments) {
+  var out = [];
+
+  comments.forEach((c) {

[blois, 2013/01/29 16:53:31]

nit- I prefer for () loops over forEach for standard loops like this.

+    out.addAll(c.split(new RegExp('\n')));
+  });
+
+  return out;
+}
+
 /// Given the class mirror, returns the names found or an empty list.
 List<String> domNames(DeclarationMirror mirror) {
   var domNameMetadata = findMetadata(mirror.metadata, 'DomName');
 
   if (domNameMetadata != null) {
     var domNames = <String>[];
     var tags = deprecatedFutureValue(domNameMetadata.getField('name'));
     for (var s in tags.reflectee.split(',')) {
       domNames.add(s.trim());
     }
 
     if (domNames.length == 1 && domNames[0] == 'none') return <String>[];
     return domNames;
   } else {
     return <String>[];
   }
 }