Give rationale for style guide, suggest using more concise code when doing so doesn't harm readabil…

Give rationale for style guide, suggest using more concise code when doing so doesn't harm readability.
TBR=abarth

Committed: https://chromium.googlesource.com/external/mojo/+/053b0a564b07ee51bcefcb17baf8f52f496732de

[Hixie, 2015-06-25 17:14:01]

Committed patchset #1 (id:1) manually as
053b0a564b07ee51bcefcb17baf8f52f496732de (presubmit successful).

[abarth-chromium, 2015-06-25 17:17:13]

https://codereview.chromium.org/1209003002/diff/1/sky/specs/style-guide.md
File sky/specs/style-guide.md (right):

https://codereview.chromium.org/1209003002/diff/1/sky/specs/style-guide.md#ne...
sky/specs/style-guide.md:99: >       add(child);
The usual Google style for this situation is to put a { } around a single
statement if that statement occupies more than one physical line.  For example,
this could would become:

if (children != null) {
  for (RenderBox child in children)
    add(child);
}

Because the body of the |if| takes up more than one physical line.

[Hixie, 2015-06-25 18:20:28]

On 2015/06/25 at 17:17:13, abarth wrote:
> https://codereview.chromium.org/1209003002/diff/1/sky/specs/style-guide.md
> File sky/specs/style-guide.md (right):
> 
>
https://codereview.chromium.org/1209003002/diff/1/sky/specs/style-guide.md#ne...
> sky/specs/style-guide.md:99: >       add(child);
> The usual Google style for this situation is to put a { } around a single
statement if that statement occupies more than one physical line.  For example,
this could would become:
> 
> if (children != null) {
>   for (RenderBox child in children)
>     add(child);
> }
> 
> Because the body of the |if| takes up more than one physical line.

In the actual case that code came from, that ends up being ugly:

void foo() {
  if (bar) {
    for (var x in y)
      baz(x);
  }
}

...vs:

void foo() {
  if (bar)
    for (var x in y)
      baz(x);
}

...but I can see how it would make sense in larger blocks. Not sure how to
phrase it in a way that the style guide itself remains readable and
understandable to anyone but language lawyers...

[abarth-chromium, 2015-06-25 18:37:47]

Can't we just say "Use curly braces of the body of the if-statement or loop
takes up more than one line of text."  ?