Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 12090010: Added result cids to some natives (byte array _new). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 17680)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -1786,6 +1786,34 @@
}
+static intptr_t GetResultCidOfNative(const Function& function) {
+ const Class& function_class = Class::Handle(function.Owner());
+ if (function_class.library() == Library::ScalarlistLibrary()) {
+ const String& function_name = String::Handle(function.name());
+ if (!String::EqualsIgnoringPrivateKey(function_name, Symbols::_New())) {
+ return kDynamicCid;
+ }
+ switch (function_class.id()) {
+ case kInt8ArrayCid:
+ case kUint8ArrayCid:
+ case kUint8ClampedArrayCid:
+ case kInt16ArrayCid:
+ case kUint16ArrayCid:
+ case kInt32ArrayCid:
+ case kUint32ArrayCid:
+ case kInt64ArrayCid:
+ case kUint64ArrayCid:
+ case kFloat32ArrayCid:
+ case kFloat64ArrayCid:
+ return function_class.id();
+ default:
+ return kDynamicCid; // Unknown.
+ }
+ }
+ return kDynamicCid;
+}
+
+
// <Expression> ::= StaticCall { function: Function
// arguments: <ArgumentList> }
void EffectGraphVisitor::VisitStaticCallNode(StaticCallNode* node) {
@@ -1821,6 +1849,10 @@
node->function(),
node->arguments()->names(),
arguments);
+ if (node->function().is_native()) {
+ const intptr_t result_cid = GetResultCidOfNative(node->function());
+ call->set_result_cid(result_cid);
+ }
ReturnDefinition(call);
}
« no previous file with comments | « no previous file | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698