Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 12090006: Omnibox: Create Keyword Verbatim Result in Search Provider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more extension cleanup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index edcc4a6fc6ea4b51201ad82f7beb4211bdaf4e46..5e321dd2e6815ced010146d6afec99428edef549 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -3,9 +3,9 @@
// found in the LICENSE file.
//
// This file contains the Search autocomplete provider. This provider is
-// responsible for all non-keyword autocomplete entries that start with
-// "Search <engine> for ...", including searching for the current input string,
-// search history, and search suggestions. An instance of it gets created and
+// responsible for all autocomplete entries that start with "Search <engine>
+// for ...", including searching for the current input string, search
+// history, and search suggestions. An instance of it gets created and
// managed by the autocomplete controller.
#ifndef CHROME_BROWSER_AUTOCOMPLETE_SEARCH_PROVIDER_H_
@@ -293,6 +293,10 @@ class SearchProvider : public AutocompleteProvider,
int GetVerbatimRelevance() const;
// Calculate the relevance score for the verbatim result.
int CalculateRelevanceForVerbatim() const;
+ // Calculate the relevance score for the keyword verbatim result (used if
Bart N. 2013/01/29 18:50:42 Nit: We usually refer in 3rd-person when describin
Mark P 2013/01/30 19:46:21 Cleaned up some nearby comments.
+ // we have a keyword provider).
+ static int CalculateRelevanceForKeywordVerbatim(AutocompleteInput::Type type,
Bart N. 2013/01/29 18:50:42 Note: As you've seen in my pending CL (12039053),
Mark P 2013/01/30 19:46:21 Ack.
+ bool prefer_keyword);
// |time| is the time at which this query was last seen. |is_keyword|
// indicates whether the results correspond to the keyword provider or default
// provider. |prevent_inline_autocomplete| is true if we should not inline

Powered by Google App Engine
This is Rietveld 408576698