Omnibox: Create Keyword Verbatim Result in Search Provider

chrome/browser/autocomplete/keyword_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/autocomplete/keyword_provider.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_service.h"
@@ skipping 70 matching lines @@
 }
 
 TEST_F(KeywordProviderTest, Edit) {
   test_data<string16> edit_cases[] = {
     // Searching for a nonexistent prefix should give nothing.
     {ASCIIToUTF16("Not Found"),       0, {}},
     {ASCIIToUTF16("aaaaaNot Found"),  0, {}},
 
     // Check that tokenization only collapses whitespace between first tokens,
     // no-query-input cases have a space appended, and action is not escaped.
-    {ASCIIToUTF16("z foo"),           1, {ASCIIToUTF16("z foo")}},
     {ASCIIToUTF16("z"),               1, {ASCIIToUTF16("z ")}},
     {ASCIIToUTF16("z    \t"),         1, {ASCIIToUTF16("z ")}},
-    {ASCIIToUTF16("z   a   b   c++"), 1, {ASCIIToUTF16("z a   b   c++")}},
+
+    // Check that exact, substituting keywords with a verbatim search term
+    // don't generate a result.  (These are handled by SearchProvider.)
+    {ASCIIToUTF16("z foo"),           0, {}},
+    {ASCIIToUTF16("z   a   b   c++"), 0, {}},
 
     // Matches should be limited to three, and sorted in quality order, not
     // alphabetical.
     {ASCIIToUTF16("aaa"),             2, {ASCIIToUTF16("aaaa "),
                                           ASCIIToUTF16("aaaaa ")}},
     {ASCIIToUTF16("a 1 2 3"),         3, {ASCIIToUTF16("aa 1 2 3"),
                                           ASCIIToUTF16("ab 1 2 3"),
                                           ASCIIToUTF16("aaaa 1 2 3")}},
     {ASCIIToUTF16("www.a"),           3, {ASCIIToUTF16("aa "),
                                           ASCIIToUTF16("ab "),
                                           ASCIIToUTF16("aaaa ")}},
     // Exact matches should prevent returning inexact matches.

[msw, 2013/01/31 00:38:16]

nit: add a comment about the verbatim match suppression.

[Mark P, 2013/01/31 23:09:27]

Done.

-    {ASCIIToUTF16("aaaa foo"),        1, {ASCIIToUTF16("aaaa foo")}},
-    {ASCIIToUTF16("www.aaaa foo"),    1, {ASCIIToUTF16("aaaa foo")}},
+    {ASCIIToUTF16("aaaa foo"),        0, {}},
+    {ASCIIToUTF16("www.aaaa foo"),    0, {}},
 
     // Clean up keyword input properly.  "http" and "https" are the only
     // allowed schemes.
     {ASCIIToUTF16("www"),             1, {ASCIIToUTF16("www ")}},
     {ASCIIToUTF16("www."),            0, {}},
     {ASCIIToUTF16("www.w w"),         2, {ASCIIToUTF16("www w"),
                                           ASCIIToUTF16("weasel w")}},
     {ASCIIToUTF16("http://www"),      1, {ASCIIToUTF16("www ")}},
     {ASCIIToUTF16("http://www."),     0, {}},
     {ASCIIToUTF16("ftp: blah"),       0, {}},
     {ASCIIToUTF16("mailto:z"),        0, {}},
     {ASCIIToUTF16("ftp://z"),         0, {}},
     {ASCIIToUTF16("https://z"),       1, {ASCIIToUTF16("z ")}},
   };
 
   RunTest<string16>(edit_cases, arraysize(edit_cases),
                     &AutocompleteMatch::fill_into_edit);
 }
 
 TEST_F(KeywordProviderTest, URL) {
   test_data<GURL> url_cases[] = {
     // No query input -> empty destination URL.
     {ASCIIToUTF16("z"),               1, {GURL()}},
     {ASCIIToUTF16("z    \t"),         1, {GURL()}},
 
     // Check that tokenization only collapses whitespace between first tokens
     // and query input, but not rest of URL, is escaped.
-    {ASCIIToUTF16("z   a   b   c++"), 1, {GURL("a+++b+++c%2B%2B=z")}},
-    {ASCIIToUTF16("www.www www"),     1, {GURL(" +%2B?=wwwfoo ")}},
+    {ASCIIToUTF16("w  bar +baz"),     2, {GURL(" +%2B?=bar+%2Bbazfoo "),
+                                          GURL("bar+%2Bbaz=z")}},
 
     // Substitution should work with various locations of the "%s".
     {ASCIIToUTF16("aaa 1a2b"),        2, {GURL("http://aaaa/?aaaa=1&b=1a2b&c"),
                                           GURL("1a2b")}},
     {ASCIIToUTF16("a 1 2 3"),         3, {GURL("aa.com?foo=1+2+3"),
                                           GURL("bogus URL 1+2+3"),
                                         GURL("http://aaaa/?aaaa=1&b=1+2+3&c")}},
     {ASCIIToUTF16("www.w w"),         2, {GURL(" +%2B?=wfoo "),
                                           GURL("weaselwweasel")}},
   };
 
   RunTest<GURL>(url_cases, arraysize(url_cases),
                 &AutocompleteMatch::destination_url);
 }
 
 TEST_F(KeywordProviderTest, Contents) {
   test_data<string16> contents_cases[] = {
     // No query input -> substitute "<enter query>" into contents.
     {ASCIIToUTF16("z"),               1,
         {ASCIIToUTF16("Search z for <enter query>")}},
     {ASCIIToUTF16("z    \t"),         1,
         {ASCIIToUTF16("Search z for <enter query>")}},
 
-    // Check that tokenization only collapses whitespace between first tokens
-    // and contents are not escaped or unescaped.
-    {ASCIIToUTF16("z   a   b   c++"), 1,
-        {ASCIIToUTF16("Search z for a   b   c++")}},
-    {ASCIIToUTF16("www.www www"),     1, {ASCIIToUTF16("Search www for www")}},
+    // Exact keyword matches with remaining text should return nothing.
+    {ASCIIToUTF16("www.www www"),     0, {}},
+    {ASCIIToUTF16("z   a   b   c++"), 0, {}},
+
+    // Exact keyword matches with remaining text when the keyword is an
+    // extension keyword should return something.  This is tested in
+    // chrome/browser/extensions/api/omnibox/omnibox_apitest.cc's
+    // in OmniboxApiTest's Basic test.
 
     // Substitution should work with various locations of the "%s".
     {ASCIIToUTF16("aaa"),             2,
         {ASCIIToUTF16("Search aaaa for <enter query>"),
          ASCIIToUTF16("Search aaaaa for <enter query>")}},
-    {ASCIIToUTF16("a 1 2 3"),         3, {ASCIIToUTF16("Search aa for 1 2 3"),
-                                          ASCIIToUTF16("Search ab for 1 2 3"),
-                                        ASCIIToUTF16("Search aaaa for 1 2 3")}},
     {ASCIIToUTF16("www.w w"),         2, {ASCIIToUTF16("Search www for w"),
         ASCIIToUTF16("Search weasel for w")}},
+    // Also, check that tokenization only collapses whitespace between first
+    // tokens and contents are not escaped or unescaped.
+    {ASCIIToUTF16("a   1 2+ 3"),      3, {ASCIIToUTF16("Search aa for 1 2+ 3"),

[msw, 2013/01/31 00:38:16]

optional nit: wrap this and the case above like the "aaa" case on line 174.

[Mark P, 2013/01/31 23:09:27]

Done.

+                                          ASCIIToUTF16("Search ab for 1 2+ 3"),
+                                       ASCIIToUTF16("Search aaaa for 1 2+ 3")}},
   };
 
   RunTest<string16>(contents_cases, arraysize(contents_cases),
                         &AutocompleteMatch::contents);
 }
 
 TEST_F(KeywordProviderTest, DISABLED_Description) {
   test_data<string16> description_cases[] = {
     // Whole keyword should be returned for both exact and inexact matches.
     {ASCIIToUTF16("z foo"),           1, {ASCIIToUTF16("(Keyword: z)")}},
@@ skipping 31 matching lines @@
 }
 
 TEST_F(KeywordProviderTest, GetKeywordForInput) {
   EXPECT_EQ(ASCIIToUTF16("aa"),
       kw_provider_->GetKeywordForText(ASCIIToUTF16("aa")));
   EXPECT_EQ(string16(),
       kw_provider_->GetKeywordForText(ASCIIToUTF16("aafoo")));
   EXPECT_EQ(string16(),
       kw_provider_->GetKeywordForText(ASCIIToUTF16("aa foo")));
 }