Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1208993017: Add image->bitmap (Closed)

Created:
5 years, 5 months ago by reed1
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add image->bitmap BUG=skia: patch from issue 1212163012 at patchset 1 (http://crrev.com/1212163012#ps1) Committed: https://skia.googlesource.com/skia/+/3c06511e910524bf9456c532fe20d1b2956e7d97

Patch Set 1 #

Total comments: 2

Patch Set 2 : add Legacy to name, and update dox that this is raster-only #

Patch Set 3 : add test #

Patch Set 4 : #

Patch Set 5 : add check for immutable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M include/core/SkImage.h View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
M src/image/SkImage_Base.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 4 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
reed1
5 years, 5 months ago (2015-07-08 14:09:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993017/1
5 years, 5 months ago (2015-07-08 14:09:37 UTC) #4
bsalomon
On 2015/07/08 14:09:37, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 5 months ago (2015-07-08 14:16:04 UTC) #6
robertphillips
Any chance for an SkImage_Gpu specialization? tests? https://codereview.chromium.org/1208993017/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/1208993017/diff/1/include/core/SkImage.h#newcode282 include/core/SkImage.h:282: * success
5 years, 5 months ago (2015-07-08 15:41:26 UTC) #7
reed1
https://codereview.chromium.org/1208993017/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): https://codereview.chromium.org/1208993017/diff/1/include/core/SkImage.h#newcode282 include/core/SkImage.h:282: * On 2015/07/08 15:41:26, robertphillips wrote: > success Done.
5 years, 5 months ago (2015-07-08 19:14:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993017/60001
5 years, 5 months ago (2015-07-08 19:15:11 UTC) #11
reed1
On 2015/07/08 14:16:04, bsalomon wrote: > On 2015/07/08 14:09:37, commit-bot: I haz the power wrote: ...
5 years, 5 months ago (2015-07-08 19:15:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993017/80001
5 years, 5 months ago (2015-07-08 19:31:23 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 19:46:26 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/3c06511e910524bf9456c532fe20d1b2956e7d97

Powered by Google App Engine
This is Rietveld 408576698