Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1208993008: explicitly bump legacy genID on gpu surface (Closed)

Created:
5 years, 5 months ago by reed2
Modified:
5 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

explicitly bump legacy genID on gpu surface Previous attempt to "test" getTextureHandle was giving false-positive because we had an active image-snapshot, which was incidentally also triggering a new genID. I think this CL will also enable this change: https://codereview.chromium.org/1222243002/ BUG=skia: TBR=bsalomon@google.com NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/dca20ce4e1a522d6f70c79252a169456b48619db

Patch Set 1 #

Patch Set 2 : add dox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M src/image/SkSurface_Gpu.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
reed2
ptal
5 years, 5 months ago (2015-07-03 03:23:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993008/20001
5 years, 5 months ago (2015-07-03 03:23:54 UTC) #4
reed2
5 years, 5 months ago (2015-07-03 03:26:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993008/20001
5 years, 5 months ago (2015-07-03 14:20:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993008/20001
5 years, 5 months ago (2015-07-03 17:05:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208993008/20001
5 years, 5 months ago (2015-07-03 17:43:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/dca20ce4e1a522d6f70c79252a169456b48619db
5 years, 5 months ago (2015-07-03 17:43:46 UTC) #16
bsalomon
5 years, 5 months ago (2015-07-06 14:04:58 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698