Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: extensions/BUILD.gn

Issue 1208963003: Move GN obj files to target-specific dirs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: \ Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « crypto/BUILD.gn ('k') | net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/BUILD.gn
diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn
index ea66ab163f8cd73822fb0d9bd13a498758101bff..949fbe176bac154898ca36bf2e032fc31a0d25b5 100644
--- a/extensions/BUILD.gn
+++ b/extensions/BUILD.gn
@@ -2,6 +2,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# TODO(rockot) bug 505926: Don't include chrome files from here.
+# See chrome_browser_tests_extensions_sources below
+import("//chrome/chrome_tests.gni")
import("//extensions/extensions.gni")
import("//testing/test.gni")
import("//tools/grit/grit_rule.gni")
@@ -224,3 +227,115 @@ test("extensions_browsertests") {
deps += [ "shell:app_shell" ] # Needed for App Shell.app's Helper.
}
}
+
+# TODO(rockot) bug 505926: These should be moved to extensions_browsertests but have
+# old dependencies on chrome files. The chrome dependencies should be removed
+# and these moved to the extensions_browsertests target. Currently, we solve
+# the problem by making this a source set and linking it into
+# //chrome/test:browser_tests.
+source_set("chrome_extensions_browsertests") {
+ testonly = true
+ sources = rebase_path(
+ chrome_tests_gypi_values.chrome_browser_tests_extensions_sources,
+ ".",
+ "//chrome")
+
+ defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
+
+ # These are the deps from browser_tests minus some internal Chrome ones that
+ # aren't allowed to be included here and that aren't needed.
+ deps = [
+ "//base",
+ "//base:i18n",
+ "//base/allocator",
+ "//base/test:test_support",
+ "//chrome/browser",
+ "//chrome/browser/resources:extension_resource_demo",
+ "//chrome/common/extensions/api",
+ "//chrome/renderer",
+ "//components/autofill/content/browser:risk_proto",
+ "//components/autofill/content/browser/wallet:test_support",
+ "//components/autofill/content/renderer:test_support",
+ "//components/captive_portal:test_support",
+ "//components/dom_distiller/content",
+ "//components/dom_distiller/core:test_support",
+ "//components/guest_view/browser:test_support",
+ "//components/resources",
+ "//components/strings",
+ "//components/translate/core/common",
+ "//components/user_manager:test_support",
+ "//crypto:platform",
+ "//crypto:test_support",
+ "//device/bluetooth:mocks",
+ "//device/serial:test_support",
+ "//extensions/common/api",
+ "//google_apis:test_support",
+ "//media",
+ "//media/base:test_support",
+ "//media/cast:test_support",
+ "//net",
+ "//net:test_support",
+ "//sdch",
+ "//skia",
+ "//sync",
+ "//sync:test_support_sync_api",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//testing/perf",
+ "//third_party/cacheinvalidation",
+ "//third_party/icu",
+ "//third_party/leveldatabase",
+ "//third_party/libaddressinput",
+ "//third_party/libjingle",
+ "//third_party/safe_browsing:test_support",
+ "//third_party/WebKit/public:blink",
+ "//third_party/webrtc/modules/desktop_capture",
+ "//third_party/widevine/cdm:version_h",
+ "//ui/accessibility:test_support",
+ "//ui/base:test_support",
+ "//ui/compositor:test_support",
+ "//ui/resources",
+ "//ui/web_dialogs:test_support",
+ "//v8",
+ ]
+}
+
+# TODO(rockot) bug 505926: This should be deleted for the same reason as
+# chrome_extensions_browsertests.
+source_set("chrome_extensions_interactive_uitests") {
+ testonly = true
+ sources = rebase_path(
+ chrome_tests_gypi_values.chrome_interactive_ui_test_extensions_sources,
+ ".",
+ "//chrome")
+
+ defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
+
+ # These are the deps from interactive_uitests minus some internal Chrome
+ # ones that aren't allowed to be included here and that aren't needed.
+ deps = [
+ "//base/allocator",
+ "//chrome/browser",
+ "//chrome/browser/devtools",
+ "//chrome/renderer",
+ "//chrome/test:test_support",
+ "//content/app/resources",
+ "//crypto:platform",
+ "//crypto:test_support",
+ "//google_apis:test_support",
+ "//net",
+ "//net:net_resources",
+ "//net:test_support",
+ "//skia",
+ "//sync",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/hunspell",
+ "//third_party/icu",
+ "//third_party/libpng",
+ "//third_party/zlib",
+ "//ui/base:test_support",
+ "//ui/resources:ui_test_pak",
+ "//ui/web_dialogs:test_support",
+ ]
+}
« no previous file with comments | « crypto/BUILD.gn ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698