Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: extensions/BUILD.gn

Issue 1208963003: Move GN obj files to target-specific dirs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/BUILD.gn
diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn
index ea66ab163f8cd73822fb0d9bd13a498758101bff..b9d07536f59291c7041027328ac5504c7f5e1df7 100644
--- a/extensions/BUILD.gn
+++ b/extensions/BUILD.gn
@@ -2,6 +2,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# TODO(brettw) don't include chrome files from here.
+# See chrome_browser_tests_extensions_sources below
+import("//chrome/chrome_tests.gni")
Nico 2015/06/30 20:38:46 eek!
import("//extensions/extensions.gni")
import("//testing/test.gni")
import("//tools/grit/grit_rule.gni")
@@ -224,3 +227,24 @@ test("extensions_browsertests") {
deps += [ "shell:app_shell" ] # Needed for App Shell.app's Helper.
}
}
+
+# These should be moved to extensions_browsertests but have old dependencies on
+# chrome files. The chrome dependencies should be removed and these moved to
+# the extensions_browsertests target. Currently, we solve the problem by making
+# this a source set and linking it into //chrome/test:browser_tests.
+source_set("chrome_extensions_browsertests") {
+ testonly = true
+ sources = rebase_path(
+ chrome_tests_gypi_values.chrome_browser_tests_extensions_sources,
+ ".",
+ "//chrome")
+}
+
+# This should be deleted for the same reason as chrome_extensions_browsertests.
+source_set("chrome_extensions_interactive_uitests") {
+ testonly = true
+ sources = rebase_path(
+ chrome_tests_gypi_values.chrome_interactive_ui_test_extensions_sources,
+ ".",
+ "//chrome")
+}

Powered by Google App Engine
This is Rietveld 408576698