Issue 1208963002: Add simple test for MediaSession

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1208963002: Add simple test for MediaSession (Closed)

Created:
5 years, 6 months ago by davve

Modified:
5 years, 6 months ago

Reviewers:
philipj_slow, mlamouri (slow - plz ping)

CC:
blink-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri (slow - plz ping), philipj_slow, whywhat

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add simple test for MediaSession Implemented using a virtual testsuite to enable the mediasession flag. This way we don't have to have the flag enabled when running LayoutTests in general, only when running MediaSession tests. BUG=497735

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -1 line)			Patch
M	LayoutTests/VirtualTestSuites	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/media/mediasession/mediasession-constructor.html	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	LayoutTests/media/mediasession/mediasession-constructor-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/virtual/mediasession/media/mediasession/README.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	LayoutTests/virtual/mediasession/media/mediasession/mediasession-constructor-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

davve

I had to bypass hooks to able to upload the expected file to virtual/. But ...

5 years, 6 months ago (2015-06-25 15:34:51 UTC) #2

davve

5 years, 6 months ago (2015-06-26 12:23:55 UTC) #6

Message was sent while issue was closed.

Now merged into https://codereview.chromium.org/1206283002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages