Chromium Code Reviews Chromium Code Reviews
Issue 1208933004:
QUIC - disable QUIC under recent pathological connection errors. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 45cc91f35052ca012e8f8b908028caeef06f442d..aaf25d70d6327ba0df0a989cab9ba1a4709691a5 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -22542,6 +22542,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Net.QuicStreamFactory.DisabledReasons" |
| + enum="QuicDisabledReason"> |
| + <owner>ckrasic@chromium.org</owner> |
| + <summary> |
| + Records reasons QUIC is disabled (for all ports), if sufficent recent |
| + connections experience: public reset post crypto handshake, or timeouts |
|
Alexei Svitkine (slow)
2015/07/07 15:15:29
Nit: Extra space. You also have some extra spaces
Buck
2015/07/07 18:38:48
Done.
|
| + with streams open. QUIC is disabled until the next reboot of Chrome. |
|
Alexei Svitkine (slow)
2015/07/07 15:15:29
Please mention when this is logged. Same for the o
Buck
2015/07/07 18:38:49
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Net.QuicStreamFactory.PublicResetsPostHandshake"> |
|
Alexei Svitkine (slow)
2015/07/07 15:15:29
Add a units="" attr.
Buck
2015/07/07 18:38:49
Done.
|
| + \ |
|
Alexei Svitkine (slow)
2015/07/07 15:15:29
Remove \
Buck
2015/07/07 18:38:49
Done.
|
| + <owner>ckrasic@chromium.org</owner> |
| + <summary> |
| + Captures the maximum number of public resets post handshake that occurred |
| + within a window of recent connections (default 20). Will help inform the |
| + choice of threshold to disable QUIC for clients that experience |
| + pathalogical errors. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Net.QuicStreamFactory.QuicIsDisabled" enum="Ports"> |
| <owner>rtenneti@chromium.org</owner> |
| <summary> |
| @@ -22551,6 +22572,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Net.QuicStreamFactory.TimeoutsWithOpenStreams"> |
|
Alexei Svitkine (slow)
2015/07/07 15:15:29
Add a units="" attr.
Buck
2015/07/07 18:38:49
Done.
|
| + \ |
|
Alexei Svitkine (slow)
2015/07/07 15:15:29
Remove \
Buck
2015/07/07 18:38:49
Done.
|
| + <owner>ckrasic@chromium.org</owner> |
| + <summary> |
| + Captures the maximum number of connection timeouts with streams open that |
| + occurred within a window of recent connections (default 20). Will help |
| + inform the choice of threshold to disable QUIC for clients that experience |
| + pathalogical errors. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Net.QuicVerifyProofFailed.HandshakeConfirmed" |
| enum="BooleanHandshakeConfirmed"> |
| <owner>rtenneti@chromium.org</owner> |
| @@ -65189,6 +65221,12 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="5" label="FIVE_PACKETS_LOST"/> |
| </enum> |
| +<enum name="QuicDisabledReason" type="int"> |
| + <int value="1" label="Public reset post handshake"/> |
| + <int value="2" label="Timeout with open streams"/> |
| + <int value="3" label="Bad packet loss rate"/> |
| +</enum> |
| + |
| <enum name="QuicDiskCacheAPICall" type="int"> |
| <int value="0" label="Start"/> |
| <int value="1" label="WaitForDataReady"/> |
