net/quic/quic_protocol.h - Issue 1208933004: QUIC - disable QUIC under recent pathological connection errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_protocol.h

Issue 1208933004: QUIC - disable QUIC under recent pathological connection errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move dead code out of OnHandshakeConfirmed to where it will actually work (spotted by Ryan). Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_protocol.h

diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h

index 8c23d1a0584ec46575d6485d4966de5170be8d50..2c8c7894be89464d6a61e585b7836295ee9b0b10 100644

--- a/net/quic/quic_protocol.h

+++ b/net/quic/quic_protocol.h

@@ -542,6 +542,10 @@ enum QuicErrorCode {

QUIC_CONNECTION_CANCELLED = 70,

// Disabled QUIC because of high packet loss rate.

QUIC_BAD_PACKET_LOSS_RATE = 71,

+ // Disabled QUIC because of too many PUBLIC_RESETs post handshake.

+ QUIC_PUBLIC_RESETS_POST_HANDSHAKE = 73,

+ // Disabled QUIC because of too many timeouts with streams open.

+ QUIC_TIMEOUTS_WITH_OPEN_STREAMS = 74,

Ryan Hamilton 2015/07/07 03:09:37 FYI: You'll need to merge this part of your CL to

Buck 2015/07/07 18:38:48 Acknowledged.

// Crypto errors.

@@ -601,7 +605,7 @@ enum QuicErrorCode {

QUIC_VERSION_NEGOTIATION_MISMATCH = 55,

// No error. Used as bound while iterating.

- QUIC_LAST_ERROR = 73,

+ QUIC_LAST_ERROR = 75,

};

struct NET_EXPORT_PRIVATE QuicPacketPublicHeader {

« net/quic/quic_client_session.h ('K') | « net/quic/quic_client_session.cc ('k') | net/quic/quic_stream_factory.h » ('j') | net/quic/quic_stream_factory.h » ('J')