Chromium Code Reviews Chromium Code Reviews
Issue 1208933004:
QUIC - disable QUIC under recent pathological connection errors. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index a96e994d642d164532ea795b2440dc2a7e53abec..55768f23478fdd7f4a02085ddd4c1cdf7d6cf0a0 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -22607,6 +22607,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Net.QuicStreamFactory.DisabledReasons" |
| + enum="QuicDisabledReason"> |
| + <owner>ckrasic@chromium.org</owner> |
| + <summary> |
| + Rrecords reasons QUIC is disabled (for all ports), if sufficent recent |
| + connections experience: public reset post crypto handshake, or timeouts with |
| + streams open. QUIC is disabled until the next reboot of Chrome. Logged |
| + during session close. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Net.QuicStreamFactory.PublicResetsPostHandshake" units="count"> |
|
Alexei Svitkine (slow)
2015/07/07 18:44:09
Nit: Wouldn't units="resets" make more sense?
Buck
2015/07/07 18:55:20
Done.
|
| + <owner>ckrasic@chromium.org</owner> |
| + <summary> |
| + Captures the maximum number of public resets post handshake that occurred |
| + within a window of recent connections (default 20). Will help inform the |
| + choice of threshold to disable QUIC for clients that experience pathalogical |
| + errors. Logged during session close. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Net.QuicStreamFactory.QuicIsDisabled" enum="Ports"> |
| <owner>rtenneti@chromium.org</owner> |
| <summary> |
| @@ -22616,6 +22637,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Net.QuicStreamFactory.TimeoutsWithOpenStreams" units="count"> |
|
Alexei Svitkine (slow)
2015/07/07 18:44:09
units="timeouts"?
Buck
2015/07/07 18:55:20
Done.
|
| + <owner>ckrasic@chromium.org</owner> |
| + <summary> |
| + Captures the maximum number of connection timeouts with streams open that |
|
Alexei Svitkine (slow)
2015/07/07 18:44:09
Nit: You still have randomly doubled spaces in thi
Buck
2015/07/07 18:55:20
yikes, sorry I missed it! Done.
|
| + occurred within a window of recent connections (default 20). Will help |
| + inform the choice of threshold to disable QUIC for clients that experience |
| + pathalogical errors. Logged during session close. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Net.QuicVerifyProofFailed.HandshakeConfirmed" |
| enum="BooleanHandshakeConfirmed"> |
| <owner>rtenneti@chromium.org</owner> |
| @@ -65291,6 +65322,12 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="5" label="FIVE_PACKETS_LOST"/> |
| </enum> |
| +<enum name="QuicDisabledReason" type="int"> |
| + <int value="1" label="Public reset post handshake"/> |
| + <int value="2" label="Timeout with open streams"/> |
| + <int value="3" label="Bad packet loss rate"/> |
| +</enum> |
| + |
| <enum name="QuicDiskCacheAPICall" type="int"> |
| <int value="0" label="Start"/> |
| <int value="1" label="WaitForDataReady"/> |
