Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 120893002: Eliminate video capture thread in renderer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git cl upload Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 5e8db708edbb397c655e02f4a414fad57bd1aaff..d497df843aab33b3aa16687227d2580fc07cb61c 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -346,7 +346,7 @@ void RenderThreadImpl::Init() {
db_message_filter_ = new DBMessageFilter();
AddFilter(db_message_filter_.get());
- vc_manager_ = new VideoCaptureImplManager();
+ vc_manager_.reset(new VideoCaptureImplManager());
AddFilter(vc_manager_->video_capture_message_filter());
#if defined(ENABLE_WEBRTC)
@@ -360,7 +360,7 @@ void RenderThreadImpl::Init() {
webrtc_identity_service_.reset(new WebRTCIdentityService());
media_stream_factory_.reset(new MediaStreamDependencyFactory(
- vc_manager_.get(), p2p_socket_dispatcher_.get()));
+ p2p_socket_dispatcher_.get()));
AddObserver(media_stream_factory_.get());
#endif // defined(ENABLE_WEBRTC)
@@ -440,7 +440,13 @@ void RenderThreadImpl::Shutdown() {
RemoveFilter(audio_message_filter_.get());
audio_message_filter_ = NULL;
+ // |media_stream_factory_| produces users of |vc_manager_| so it must be
+ // destroyed first.
+#if defined(ENABLE_WEBRTC)
+ media_stream_factory_.reset();
+#endif
RemoveFilter(vc_manager_->video_capture_message_filter());
+ vc_manager_.reset();
RemoveFilter(db_message_filter_.get());
db_message_filter_ = NULL;

Powered by Google App Engine
This is Rietveld 408576698