Eliminate video capture thread in renderer

content/renderer/render_thread_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 74 matching lines @@
 class InputEventFilter;
 class InputHandlerManager;
 class MediaStreamCenter;
 class MediaStreamDependencyFactory;
 class MIDIMessageFilter;
 class P2PSocketDispatcher;
 class PeerConnectionTracker;
 class RendererDemuxerAndroid;
 class RendererWebKitPlatformSupportImpl;
 class RenderProcessObserver;
 class VideoCaptureImplManager;

[Ami GONE FROM CHROMIUM, 2014/01/06 23:37:14]

IMO this is worse than #include'ing v_c_i_m.h in this file, because RTI has a
public accessor returning a VCIM*, encouraging its callers to dereference that
pointer and make function calls on the underlying VCIM.  That means _they'll_
need to #include vcim.h, even though it's not obvious why.

Put another way, the public accessor on RTI makes VCIM part of the public API of
RTI, so IMO it is better to fully declare it in this file (via #include) rather
than only fwd-declare it.

Up to the content/ OWNER you get to review this, I suppose, since this file is
such a catch-all, they might prefer this way.

[Alpha Left Google, 2014/01/08 00:23:36]

This seems to be the style used throughout this file so I'd just keep this.

 class WebGraphicsContext3DCommandBufferImpl;
 class WebRTCIdentityService;
 
 // The RenderThreadImpl class represents a background thread where RenderView
 // instances live.  The RenderThread supports an API that is used by its
 // consumer to talk indirectly to the RenderViews and supporting objects.
 // Likewise, it provides an API for the RenderViews to talk back to the main
 // process (i.e., their corresponding WebContentsImpl).
 //
 // Most of the communication occurs in the form of IPC messages.  They are
@@ skipping 319 matching lines @@
 
   scoped_ptr<MediaStreamDependencyFactory> media_stream_factory_;
 
   // This is used to communicate to the browser process the status
   // of all the peer connections created in the renderer.
   scoped_ptr<PeerConnectionTracker> peer_connection_tracker_;
 
   // Dispatches all P2P sockets.
   scoped_refptr<P2PSocketDispatcher> p2p_socket_dispatcher_;
 
   // Used on multiple threads.

[Ami GONE FROM CHROMIUM, 2014/01/06 23:37:14]

This comment is now a lie.

[Alpha Left Google, 2014/01/08 00:23:36]

Done.

-  scoped_refptr<VideoCaptureImplManager> vc_manager_;
+  scoped_ptr<VideoCaptureImplManager> vc_manager_;
 
 #if defined(OS_WIN)
   // Initialize COM when using plugins outside the sandbox.
   scoped_ptr<base::win::ScopedCOMInitializer> initialize_com_;
 #endif
 
   // The count of RenderWidgets running through this thread.
   int widget_count_;
 
   // The count of hidden RenderWidgets running through this thread.
@@ skipping 64 matching lines @@
   // multiple threads. Current allocation mechanism for IOSurface
   // backed GpuMemoryBuffers prevent this. crbug.com/325045
   base::ThreadChecker allocate_gpu_memory_buffer_thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_