Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12089107: Determine number of available cores on all platforms. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)
Modified:
7 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Determine number of available cores on all platforms. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13676

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M src/platform.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/platform-cygwin.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-freebsd.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-macos.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-nullos.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-openbsd.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/cctest/test-platform.cc View 1 2 3 4 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hannes Payer (out of office)
7 years, 10 months ago (2013-02-01 12:15:23 UTC) #1
Michael Starzinger
This code needs either tests or usages in the code-base.
7 years, 10 months ago (2013-02-13 17:43:55 UTC) #2
Hannes Payer (out of office)
Added a test file to cctest for general platform code.
7 years, 10 months ago (2013-02-15 10:16:32 UTC) #3
Michael Starzinger
https://codereview.chromium.org/12089107/diff/7001/test/cctest/test-platform.cc File test/cctest/test-platform.cc (right): https://codereview.chromium.org/12089107/diff/7001/test/cctest/test-platform.cc#newcode1 test/cctest/test-platform.cc:1: // Copyright 2006-2008 the V8 project authors. All rights ...
7 years, 10 months ago (2013-02-15 10:36:45 UTC) #4
Hannes Payer (out of office)
https://codereview.chromium.org/12089107/diff/7001/test/cctest/test-platform.cc File test/cctest/test-platform.cc (right): https://codereview.chromium.org/12089107/diff/7001/test/cctest/test-platform.cc#newcode1 test/cctest/test-platform.cc:1: // Copyright 2006-2008 the V8 project authors. All rights ...
7 years, 10 months ago (2013-02-15 10:42:18 UTC) #5
Michael Starzinger
7 years, 10 months ago (2013-02-15 10:50:22 UTC) #6 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698