Make most code on mac compile with enable_web_intents=0

Make most code on mac compile with enable_web_intents=0

Once everything builds with that set, I'll switch the default
of that to off, then merge that into webkit and delete the
webkit pieces, and then I'll delete the chromium bits.

Since enable_web_intents is still 1, this change has no observable effect.

BUG=173194
TEST=build with GYP_DEFINES=enable_web_intents=0. No compile errors,
fewer linker errors.
TBR=jschuh

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180186

[Nico, 2013-02-01 00:30:59]

sail: review

benwells: I saw some of the code mention intent support for apps. That has never
shipped, right? (Context: I'm deleting all the web intents code.)

[sail, 2013-02-01 00:37:59]

LGTM
I don't quite follow why this is needed though. Couldn't we just delete all this
code?

[Nico, 2013-02-01 00:40:45]

On 2013/02/01 00:37:59, sail wrote:
> LGTM
> I don't quite follow why this is needed though. Couldn't we just delete all
this
> code?

The code in WebKit depends on some of this and the other way round. The code
needs to become inactive in chromium and webkit at the same time.

I'm making webkit build fine with enable_web_intents here:
https://bugs.webkit.org/show_bug.cgi?id=108408

Once that's in, I can switch enable_web_intents to 0 which will disable the
chromium and webkit bits at the same time. After that, the can go.


benwells: Since this CL doesn't have an observable effect I'll go ahead with it,
but I'm very curious to know the answer to my quesiton.

[Nico, 2013-02-01 00:41:31]

piman: content/
tony: webkit/

[tony, 2013-02-01 00:44:40]

webkit lgtm

[piman, 2013-02-01 02:06:16]

lgtm

[Greg Billock, 2013-02-01 05:40:44]

On 2013/02/01 02:06:16, piman wrote:
> lgtm

At one point ChromeOS ECHO was still using intents. You should check whether it
still is before submitting.

[Nico, 2013-02-01 16:27:34]

On Thu, Jan 31, 2013 at 9:40 PM,  <gbillock@chromium.org> wrote:
> On 2013/02/01 02:06:16, piman wrote:
>>
>> lgtm
>
>
> At one point ChromeOS ECHO was still using intents.

What is ChromeOS ECHO?

> You should check whether it still is before submitting.

As mentioned in the CL description, this CL has no observable effect:
It doesn't turn off intents, it just makes the code compile on mac
(but not link yet) if someone sets enable_web_intents=0 locally.


>
> https://codereview.chromium.org/12089102/

[gbillock, 2013-02-01 16:40:36]

ChromeOS ECHO = promotion for, e.g. Drive. Some third parties as well, I
believe.

Sorry, I just looked at this as I was leaving yesterday, and wanted to make
sure you know about ECHO before any disabling changes went in. Their goal
was to move off, but I haven't heard that they have yet.


On Fri, Feb 1, 2013 at 8:27 AM, Nico Weber <thakis@chromium.org> wrote:

> On Thu, Jan 31, 2013 at 9:40 PM,  <gbillock@chromium.org> wrote:
> > On 2013/02/01 02:06:16, piman wrote:
> >>
> >> lgtm
> >
> >
> > At one point ChromeOS ECHO was still using intents.
>
> What is ChromeOS ECHO?
>
> > You should check whether it still is before submitting.
>
> As mentioned in the CL description, this CL has no observable effect:
> It doesn't turn off intents, it just makes the code compile on mac
> (but not link yet) if someone sets enable_web_intents=0 locally.
>
>
> >
> > https://codereview.chromium.org/12089102/
>

[Nico, 2013-02-01 16:41:16]

Who's a good contact for this?

On Fri, Feb 1, 2013 at 8:40 AM, Greg Billock <gbillock@google.com> wrote:
> ChromeOS ECHO = promotion for, e.g. Drive. Some third parties as well, I
> believe.
>
> Sorry, I just looked at this as I was leaving yesterday, and wanted to make
> sure you know about ECHO before any disabling changes went in. Their goal
> was to move off, but I haven't heard that they have yet.

Have web intents ever made it into a stable release?

>
>
> On Fri, Feb 1, 2013 at 8:27 AM, Nico Weber <thakis@chromium.org> wrote:
>>
>> On Thu, Jan 31, 2013 at 9:40 PM,  <gbillock@chromium.org> wrote:
>> > On 2013/02/01 02:06:16, piman wrote:
>> >>
>> >> lgtm
>> >
>> >
>> > At one point ChromeOS ECHO was still using intents.
>>
>> What is ChromeOS ECHO?
>>
>> > You should check whether it still is before submitting.
>>
>> As mentioned in the CL description, this CL has no observable effect:
>> It doesn't turn off intents, it just makes the code compile on mac
>> (but not link yet) if someone sets enable_web_intents=0 locally.
>>
>>
>> >
>> > https://codereview.chromium.org/12089102/
>
>

[gbillock, 2013-02-01 17:15:54]

gauravsh


On Fri, Feb 1, 2013 at 8:41 AM, Nico Weber <thakis@chromium.org> wrote:

> Who's a good contact for this?
>
> On Fri, Feb 1, 2013 at 8:40 AM, Greg Billock <gbillock@google.com> wrote:
> > ChromeOS ECHO = promotion for, e.g. Drive. Some third parties as well, I
> > believe.
> >
> > Sorry, I just looked at this as I was leaving yesterday, and wanted to
> make
> > sure you know about ECHO before any disabling changes went in. Their goal
> > was to move off, but I haven't heard that they have yet.
>
> Have web intents ever made it into a stable release?
>
> >
> >
> > On Fri, Feb 1, 2013 at 8:27 AM, Nico Weber <thakis@chromium.org> wrote:
> >>
> >> On Thu, Jan 31, 2013 at 9:40 PM,  <gbillock@chromium.org> wrote:
> >> > On 2013/02/01 02:06:16, piman wrote:
> >> >>
> >> >> lgtm
> >> >
> >> >
> >> > At one point ChromeOS ECHO was still using intents.
> >>
> >> What is ChromeOS ECHO?
> >>
> >> > You should check whether it still is before submitting.
> >>
> >> As mentioned in the CL description, this CL has no observable effect:
> >> It doesn't turn off intents, it just makes the code compile on mac
> >> (but not link yet) if someone sets enable_web_intents=0 locally.
> >>
> >>
> >> >
> >> > https://codereview.chromium.org/12089102/
> >
> >
>

[commit-bot: I haz the power, 2013-02-01 17:55:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/12089102/10001

[commit-bot: I haz the power, 2013-02-01 17:55:50]

Presubmit check for 12089102-10001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common/intents_messages.h

Presubmit checks took 2.7s to calculate.

[Nico, 2013-02-01 17:59:35]

jschuh: TBRing the trivial _messages.h change.

[commit-bot: I haz the power, 2013-02-01 17:59:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/12089102/10001

[commit-bot: I haz the power, 2013-02-01 18:10:56]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-02-01 18:25:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/12089102/7003

[commit-bot: I haz the power, 2013-02-01 18:57:58]

Failed to trigger a try job on win_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-02-01 19:01:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/12089102/4002

[commit-bot: I haz the power, 2013-02-01 20:22:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-01 20:22:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/12089102/5042