Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: utils/pub/validator.dart

Issue 12089076: Add a pub validator for compiled dartdoc output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/utils.dart ('k') | utils/pub/validator/compiled_dartdoc.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library validator; 5 library validator;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'entrypoint.dart'; 9 import 'entrypoint.dart';
10 import 'log.dart' as log; 10 import 'log.dart' as log;
11 import 'io.dart'; 11 import 'io.dart';
12 import 'system_cache.dart'; 12 import 'system_cache.dart';
13 import 'utils.dart'; 13 import 'utils.dart';
14 import 'validator/compiled_dartdoc.dart';
14 import 'validator/dependency.dart'; 15 import 'validator/dependency.dart';
15 import 'validator/directory.dart'; 16 import 'validator/directory.dart';
16 import 'validator/lib.dart'; 17 import 'validator/lib.dart';
17 import 'validator/license.dart'; 18 import 'validator/license.dart';
18 import 'validator/name.dart'; 19 import 'validator/name.dart';
19 import 'validator/pubspec_field.dart'; 20 import 'validator/pubspec_field.dart';
20 21
21 /// The base class for validators that check whether a package is fit for 22 /// The base class for validators that check whether a package is fit for
22 /// uploading. Each validator should override [errors], [warnings], or both to 23 /// uploading. Each validator should override [errors], [warnings], or both to
23 /// return lists of errors or warnings to display to the user. Errors will cause 24 /// return lists of errors or warnings to display to the user. Errors will cause
(...skipping 19 matching lines...) Expand all
43 /// The future will complete with the error and warning messages, 44 /// The future will complete with the error and warning messages,
44 /// respectively. 45 /// respectively.
45 static Future<Pair<List<String>, List<String>>> runAll( 46 static Future<Pair<List<String>, List<String>>> runAll(
46 Entrypoint entrypoint) { 47 Entrypoint entrypoint) {
47 var validators = [ 48 var validators = [
48 new LibValidator(entrypoint), 49 new LibValidator(entrypoint),
49 new LicenseValidator(entrypoint), 50 new LicenseValidator(entrypoint),
50 new NameValidator(entrypoint), 51 new NameValidator(entrypoint),
51 new PubspecFieldValidator(entrypoint), 52 new PubspecFieldValidator(entrypoint),
52 new DependencyValidator(entrypoint), 53 new DependencyValidator(entrypoint),
53 new DirectoryValidator(entrypoint) 54 new DirectoryValidator(entrypoint),
55 new CompiledDartdocValidator(entrypoint)
54 ]; 56 ];
55 57
56 return Future.wait(validators.mappedBy((validator) => validator.validate())) 58 return Future.wait(validators.mappedBy((validator) => validator.validate()))
57 .then((_) { 59 .then((_) {
58 var errors = 60 var errors =
59 flatten(validators.mappedBy((validator) => validator.errors)); 61 flatten(validators.mappedBy((validator) => validator.errors));
60 var warnings = 62 var warnings =
61 flatten(validators.mappedBy((validator) => validator.warnings)); 63 flatten(validators.mappedBy((validator) => validator.warnings));
62 64
63 if (!errors.isEmpty) { 65 if (!errors.isEmpty) {
64 log.error("Missing requirements:"); 66 log.error("Missing requirements:");
65 for (var error in errors) { 67 for (var error in errors) {
66 log.error("* ${Strings.join(error.split('\n'), '\n ')}"); 68 log.error("* ${Strings.join(error.split('\n'), '\n ')}");
67 } 69 }
68 log.error(""); 70 log.error("");
69 } 71 }
70 72
71 if (!warnings.isEmpty) { 73 if (!warnings.isEmpty) {
72 log.warning("Suggestions:"); 74 log.warning("Suggestions:");
73 for (var warning in warnings) { 75 for (var warning in warnings) {
74 log.warning("* ${Strings.join(warning.split('\n'), '\n ')}"); 76 log.warning("* ${Strings.join(warning.split('\n'), '\n ')}");
75 } 77 }
76 log.warning(""); 78 log.warning("");
77 } 79 }
78 80
79 return new Pair<List<String>, List<String>>(errors, warnings); 81 return new Pair<List<String>, List<String>>(errors, warnings);
80 }); 82 });
81 } 83 }
82 } 84 }
OLDNEW
« no previous file with comments | « utils/pub/utils.dart ('k') | utils/pub/validator/compiled_dartdoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698