IO v2: Handle illegal arguments to socket writes

runtime/bin/socket_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class RawServerSocket  {
   /* patch */ static Future<RawServerSocket> bind([String address = "127.0.0.1",
                                                    int port = 0,
                                                    int backlog = 0]) {
     return _RawServerSocket.bind(address, port, backlog);
   }
@@ skipping 672 matching lines @@
           offset = 0;
           write();
         },
         onDone: () {
           socket._consumerDone();
         });
     return socket._doneFuture;
   }
 
   void write() {
-    if (subscription == null) return;
-    assert(buffer != null);
-    // Write as much as possible.
-    offset += socket._write(buffer, offset, buffer.length - offset);
-    if (offset < buffer.length) {
-      if (!paused) {
-        paused = true;
-        // TODO(ajohnsen): It would be nice to avoid this check.
-        // Some info: socket._write can emit an event, if it fails to write.
-        // If the user closes the socket in that event, stop() will be called
-        // before we get a change to pause.
-        if (subscription == null) return;
-        subscription.pause();
+    try {
+      if (subscription == null) return;
+      assert(buffer != null);
+      // Write as much as possible.
+        offset += socket._write(buffer, offset, buffer.length - offset);

[Mads Ager (google), 2013/01/31 07:53:30]

Accidental indentation change?

[Søren Gjesse, 2013/01/31 12:12:01]

Done.

+      if (offset < buffer.length) {
+        if (!paused) {
+          paused = true;
+          // TODO(ajohnsen): It would be nice to avoid this check.
+          // Some info: socket._write can emit an event, if it fails to write.
+          // If the user closes the socket in that event, stop() will be called
+          // before we get a change to pause.
+          if (subscription == null) return;
+          subscription.pause();
+        }
+        socket._enableWriteEvent();
+      } else {
+        buffer = null;
+        if (paused) {
+          paused = false;
+          subscription.resume();
+        }
       }
-      socket._enableWriteEvent();
-    } else {
-      buffer = null;
-      if (paused) {
-        paused = false;
-        subscription.resume();
-      }
+    } catch (e) {
+      socket._consumerDone(e);
     }
   }
 
   void stop() {
     if (subscription == null) return;
     subscription.cancel();
     subscription = null;
     socket._disableWriteEvent();
   }
 }
@@ skipping 175 matching lines @@
   void _enableWriteEvent() {
     _raw.writeEventsEnabled = true;
   }
 
   void _disableWriteEvent() {
     if (_raw != null) {
       _raw.writeEventsEnabled = false;
     }
   }
 
-  void _consumerDone() {
+  void _consumerDone([error]) {
     if (_raw != null) {
       _raw.shutdown(SocketDirection.SEND);
       _disableWriteEvent();
     }
-    _done();
+    _done(error);
   }
 }
 
 
 class _SecureSocket extends _Socket implements SecureSocket {
   _SecureSocket(RawSecureSocket raw) : super(raw);
 
   void set onBadCertificate(bool callback(X509Certificate certificate)) {
     if (_raw == null) {
       throw new StateError("onBadCertificate called on destroyed SecureSocket");
     }
     _raw.onBadCertificate = callback;
   }
 
   X509Certificate get peerCertificate {
     if (_raw == null) {
      throw new StateError("peerCertificate called on destroyed SecureSocket");
     }
     return _raw.peerCertificate;
   }
 }