Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(53)

Issue 12089070: Merge 141160 (Closed)

Created:
8 years, 1 month ago by Justin Novosad
Modified:
8 years, 1 month ago
Reviewers:
junov1
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 141160 > REGRESSION (r135628-135632): Double box shadow failure to render > https://bugs.webkit.org/show_bug.cgi?id=107833 > > Reviewed by Simon Fraser. > > Source/WebCore: > > Regression caused by http://trac.webkit.org/changeset/135629 > The regression was due to faulty occlusion logic that was assuming > that drawing the background color of a render box background layer > could be skipped when the same layer also has an opaque image attached. > In the case where the background color is drawn for the purpose of > rendering a box shadow, the shadow is typically not > completely occluded by the background image because of the shadow > blur and/or offset. This patch fixes the problem by not culling a > background draw if it is used to draw a box shadow. > > Test: fast/backgrounds/gradient-background-shadow.html > > * rendering/RenderBoxModelObject.cpp: > (WebCore::RenderBoxModelObject::paintFillLayerExtended): > Changing occlusion culling test to never cull background color > draw if it is used to draw a box shadow. This is because box shadows > can draw outside the border fill region. > > LayoutTests: > > New ref test verifies that box shadow is drawn when > background is an opaque image. Test uses an blue gradient > as background image. Reference uses blue background color. > > * fast/backgrounds/gradient-background-shadow-expected.html: Added. > * fast/backgrounds/gradient-background-shadow.html: Added. > TBR=junov@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -167 lines) Patch
A + LayoutTests/fast/backgrounds/gradient-background-shadow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/backgrounds/gradient-background-shadow-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 60 chunks +220 lines, -146 lines 0 comments Download
M Source/WebCore/rendering/RenderBoxModelObject.cpp View 1 chunk +25 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Justin Novosad
8 years, 1 month ago (2013-01-30 15:03:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698