Add management.uninstallSelf to API

chrome/browser/extensions/api/management/management_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_MANAGEMENT_MANAGEMENT_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_MANAGEMENT_MANAGEMENT_API_H_
 
 #include "base/compiler_specific.h"
 #include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
 #include "chrome/browser/extensions/event_router.h"
@@ skipping 113 matching lines @@
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.uninstall");
 
   ManagementUninstallFunction();
   static void SetAutoConfirmForTest(bool should_proceed);
 
   // ExtensionUninstallDialog::Delegate implementation.
   virtual void ExtensionUninstallAccepted() OVERRIDE;
   virtual void ExtensionUninstallCanceled() OVERRIDE;
 
- private:
+ protected:
   virtual ~ManagementUninstallFunction();
 
+  bool DoUninstall(bool show_confirm_dialog);
+  void set_extension_id(const std::string& extension_id);
+
+ private:
   virtual bool RunImpl() OVERRIDE;
 
   // If should_uninstall is true, this method does the actual uninstall.
   // If |show_uninstall_dialog|, then this function will be called by one of the
   // Accepted/Canceled callbacks. Otherwise, it's called directly from RunImpl.
   void Finish(bool should_uninstall);
 
   std::string extension_id_;
   scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;
 };
 
+class ManagementUninstallSelfFunction : public ManagementUninstallFunction {

[koz (OOO until 15th September), 2013/01/29 05:20:26]

It's not common for functions to subclass each other like this. More common
would be to have a ManagementUninstallFunctionBase class and then have two
subclasses ManagementUninstallFunction and ManagementUninstallSelfFunction.

Would you mind refactoring this code to be like that? In the base class you
could have an Uninstall(const std::string& extension_id, bool
show_confirm_dialog) and remove the need for a set_extension_id() method, too.

[calamity, 2013/01/29 06:06:16]

Done.

+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("management.uninstallSelf");
+
+  ManagementUninstallSelfFunction();
+
+ private:
+  virtual ~ManagementUninstallSelfFunction();
+
+  virtual bool RunImpl() OVERRIDE;
+};
+
 class ManagementEventRouter : public content::NotificationObserver {
  public:
   explicit ManagementEventRouter(Profile* profile);
   virtual ~ManagementEventRouter();
 
  private:
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
@@ skipping 34 matching lines @@
 
   // Created lazily upon OnListenerAdded.
   scoped_ptr<ManagementEventRouter> management_event_router_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagementAPI);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_MANAGEMENT_MANAGEMENT_API_H_