Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12089034: Add a WebUIControllerFactory in content and move chrome://webrtc-internals to content. (Closed)

Created:
7 years, 10 months ago by jam
Modified:
7 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, arv (Not doing code reviews), jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add a WebUIControllerFactory in content and move chrome://webrtc-internals to content. BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179425

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -884 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_internals.h View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_internals.cc View 1 2 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/media/chrome_webrtc_internals_unittest.cc View 1 2 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/media/webrtc_internals_ui_observer.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/webrtc_internals/webrtc_internals.css View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/webrtc_internals/webrtc_internals.html View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/webrtc_internals/webrtc_internals.js View 1 2 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/media/webrtc_internals_message_handler.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/media/webrtc_internals_message_handler.cc View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/webui/media/webrtc_internals_ui.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/webui/media/webrtc_internals_ui.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
A + content/browser/media/resources/webrtc_internals.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/media/resources/webrtc_internals.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/media/resources/webrtc_internals.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/media/webrtc_internals.h View 1 3 chunks +34 lines, -19 lines 0 comments Download
A + content/browser/media/webrtc_internals.cc View 5 chunks +20 lines, -16 lines 0 comments Download
A + content/browser/media/webrtc_internals_message_handler.h View 2 chunks +9 lines, -5 lines 0 comments Download
A + content/browser/media/webrtc_internals_message_handler.cc View 3 chunks +10 lines, -9 lines 0 comments Download
A + content/browser/media/webrtc_internals_ui.h View 1 chunk +9 lines, -5 lines 0 comments Download
A + content/browser/media/webrtc_internals_ui.cc View 2 chunks +15 lines, -13 lines 0 comments Download
A + content/browser/media/webrtc_internals_ui_observer.h View 3 chunks +7 lines, -3 lines 0 comments Download
A + content/browser/media/webrtc_internals_unittest.cc View 7 chunks +32 lines, -30 lines 0 comments Download
M content/browser/renderer_host/media/peer_connection_tracker_host.cc View 1 2 2 chunks +14 lines, -21 lines 0 comments Download
A content/browser/webui/content_web_ui_controller_factory.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/browser/webui/content_web_ui_controller_factory.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M content/content_resources.grd View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D content/public/browser/webrtc_internals.h View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
M content/public/common/url_constants.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/url_constants.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years, 10 months ago (2013-01-29 03:18:38 UTC) #1
jam
redirecting to scottmg since jiayl isn't a committer
7 years, 10 months ago (2013-01-29 21:03:59 UTC) #2
scottmg
7 years, 10 months ago (2013-01-29 21:34:35 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698