sdk/lib/_internal/compiler/implementation/lib/js_array.dart - Issue 12089023: Don't use ReversedListView from outside core and collection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 12089023: Don't use ReversedListView from outside core and collection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/swarm/swarm_ui_lib/observable/observable.dart ('K') | « samples/swarm/swarm_ui_lib/observable/observable.dart ('k') | sdk/lib/collection/collections.dart » ('j') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

index 654edc038a39cbf89d4fa297d720aaac5b89f4db..eeb08d29e6c71662836713462df4223af9103acd 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart

@@ -222,7 +222,7 @@ class JSArray<E> implements List<E> {

bool every(bool f(E element)) => IterableMixinWorkaround.every(this, f);

- List<E> get reversed => new ReversedListView<E>(this, 0, null);

+ List<E> get reversed => IterableMixinWorkaround.reversed(this);

Lasse Reichstein Nielsen 2013/01/29 08:11:22 The interceptor.dart library imports collections-d

Lasse Reichstein Nielsen 2013/01/29 08:11:22 Should't it be ".reversedList"?

floitsch 2013/01/29 15:41:07 It shouldn't.

floitsch 2013/01/29 15:41:07 Done.

void sort([int compare(E a, E b)]) {

checkMutable(this, 'sort');