Issue 12089015: Fix post commit comments for CL 11896028. Only nits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12089015: Fix post commit comments for CL 11896028. Only nits. (Closed)

Created:
7 years, 10 months ago by markusheintz_

Modified:
7 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Peter Kasting, Bernhard Bauer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix post commit comments for CL 11896028. Only nits. BUG=167263 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179135

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/browser/ui/content_settings/content_setting_bubble_model.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/content_settings/content_setting_image_model.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

markusheintz_

@Bernhard: Please review this CL. It addresses post commit comments from CL https://chromiumcodereview.appspot.com/11896028/ Thanks a ...

7 years, 10 months ago (2013-01-28 10:05:51 UTC) #1

markusheintz_

Forgot that Bernhard is OOO. @Jochen could you pls review these trivial and tiny changes? ...

7 years, 10 months ago (2013-01-28 10:14:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/12089015/1

7 years, 10 months ago (2013-01-28 10:33:01 UTC) #4

Message was sent while issue was closed.

Change committed as 179135