Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1208873002: Reapply "Fix receiver when calling eval() bound by with scope" (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
CC:
v8-dev, Michael Hablich, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reapply "Fix receiver when calling eval() bound by with scope" Originally applied in https://codereview.chromium.org/1202963005 BUG=v8:4214 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel LOG=N R=arv@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/40b7d874b27ff19c82f6f42c23f3ea30e26100b1 Cr-Commit-Position: refs/heads/master@{#29293}

Patch Set 1 #

Patch Set 2 : Record source position of "eval" in eval lookup calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -325 lines) Patch
M src/arm/full-codegen-arm.cc View 1 4 chunks +50 lines, -41 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 4 chunks +48 lines, -39 lines 0 comments Download
M src/ast.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 4 chunks +47 lines, -38 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 4 chunks +50 lines, -41 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 4 chunks +50 lines, -41 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 4 chunks +48 lines, -42 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 4 chunks +47 lines, -37 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 4 chunks +47 lines, -38 lines 0 comments Download
A + test/mjsunit/regress/regress-4214.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wingo
Patch 1 is what landed originally. Patch 2 records the source location for the callee ...
5 years, 6 months ago (2015-06-25 12:41:09 UTC) #2
arv (Not doing code reviews)
LGTM Pro tip: If you add the following line to the CL description it will ...
5 years, 6 months ago (2015-06-25 13:01:52 UTC) #3
wingo
On 2015/06/25 13:01:52, arv wrote: > LGTM > > Pro tip: If you add the ...
5 years, 6 months ago (2015-06-25 13:10:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208873002/20001
5 years, 6 months ago (2015-06-25 13:10:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 13:46:38 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 13:46:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40b7d874b27ff19c82f6f42c23f3ea30e26100b1
Cr-Commit-Position: refs/heads/master@{#29293}

Powered by Google App Engine
This is Rietveld 408576698